Merged
Conversation
added 2 commits
November 5, 2020 11:42
Contributor
|
Pinging @elastic/kibana-platform (Team:Platform) |
pgayvallet
approved these changes
Nov 9, 2020
Contributor
pgayvallet
left a comment
There was a problem hiding this comment.
thanks for doing this
Author
|
@elasticmachine merge upstream |
Contributor
💚 Build SucceededMetrics [docs]
History
To update your PR or re-run it, just comment with: |
LeeDr
pushed a commit
to LeeDr/kibana
that referenced
this pull request
Nov 9, 2020
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Author
|
NOTE: The page object methods this test uses are not in 7.10 branch so I'll also not backport this test change to that branch. |
LeeDr
pushed a commit
that referenced
this pull request
Nov 9, 2020
gmmorris
added a commit
to gmmorris/kibana
that referenced
this pull request
Nov 10, 2020
* master: (39 commits) Fix ilm navigation (elastic#81664) [Lens] Distinct icons for XY and pie chart value labels toolbar (elastic#82927) [data.search.aggs] Throw an error when trying to create an agg type that doesn't exist. (elastic#81509) Index patterns api - load field list on server (elastic#82629) New events resolver (elastic#82170) [App Search] Misc naming tech debt (elastic#82770) load empty_kibana in test to have clean starting point (elastic#82772) Remove data <--> expressions circular dependencies. (elastic#82685) Update 8.0 breaking change template to gather information on how to programmatically detect it. (elastic#82905) Add alerting as codeowners to related documentation folder (elastic#82777) Add captions to user and space grid pages (elastic#82713) add alternate path for x-pack/Cloud test for Lens (elastic#82634) Uses asCurrentUser in getClusterUuid (elastic#82908) [Alerting][Connectors] Add new executor subaction to get 3rd party case fields (elastic#82519) Fix test import objects (elastic#82767) [ML] Add option for anomaly charts for metric detector should plot min, mean or max as appropriate (elastic#81662) Update alert type selection layout to rows instead of grid (elastic#73665) Prevent Kerberos and PKI providers from initiating a new session for unauthenticated XHR/API requests. (elastic#82817) Update grunt and related packages (elastic#79327) Allow the repository to search across all namespaces (elastic#82863) ...
LeeDr
pushed a commit
to LeeDr/kibana
that referenced
this pull request
Nov 18, 2020
LeeDr
pushed a commit
that referenced
this pull request
Nov 18, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
I think this test must have been failing on Cloud but I didn't find an open issue for it. It could only pass when run against a Kibana instance which had this setting
--savedObjects.maxImportPayloadBytes=10485760'(from the OSS functional test config file).That setting isn't in the allow list of Kibana parameters on Cloud so I wrapped the test in a
describeand askipCloudtag.The test can be run against Kibana with x-pack and security enabled if that setting is added to the config. I added that setting to x-pack/test/functional/config.js so I could run it locally. We don't have any Jenkins jobs running the OSS tests this way now but we may at some point. And it shouldn't impact any other tests (we'll see).
Checklist
Delete any items that are not applicable to this PR.