SavedObjects search_dsl: add match_phrase_prefix clauses when using prefix search#82693
Merged
pgayvallet merged 3 commits intoelastic:masterfrom Nov 9, 2020
Merged
Conversation
Contributor
|
Pinging @elastic/kibana-platform (Team:Platform) |
rudolf
approved these changes
Nov 6, 2020
Contributor
rudolf
left a comment
There was a problem hiding this comment.
Left a question, but otherwise lgtm
Comment on lines
+287
to
+296
| return mppFields.map(({ field, boost }) => { | ||
| return { | ||
| match_phrase_prefix: { | ||
| [field]: { | ||
| query, | ||
| boost, | ||
| }, | ||
| }, | ||
| }; | ||
| }); |
Contributor
There was a problem hiding this comment.
Don't really know how this API works, but does it matter that we're creating a query like:
"should": [
{
"simple_query_string": {
"query": "my-vis*",
"fields": [
"visualization.title",
"visualization.description"
],
"default_operator": "OR"
}
},
{
"match_phrase_prefix": {
"visualization.title": {
"query": "my-vis",
"boost": 1
}
}
},
{
"match_phrase_prefix": {
"visualization.description": {
"query": "my-vis",
"boost": 1
}
}
}
]
I was expecting it to be:
"should": [
{
"simple_query_string": {
"query": "my-vis*",
"fields": [
"visualization.title",
"visualization.description"
],
"default_operator": "OR"
}
},
{
"match_phrase_prefix": {
"visualization.title": {
"query": "my-vis",
"boost": 1
},
"visualization.description": {
"query": "my-vis",
"boost": 1
}
}
}
]
Contributor
Author
There was a problem hiding this comment.
I also was tbh. But match_phrase prefix does not work that way unfortunately (and even if it was, I would expect your syntax to be a AND condition between the fields, where we want a OR). That can creates a lot of clauses in the bool query, but when I discussed it with the ES teams, they told me it should not impact performances in any significative way.
Contributor
❤️ |
pgayvallet
added a commit
to pgayvallet/kibana
that referenced
this pull request
Nov 9, 2020
…refix search (elastic#82693) * add match_phrase_prefix clauses when using prefix search * add FTR tests
pgayvallet
added a commit
to pgayvallet/kibana
that referenced
this pull request
Nov 9, 2020
…refix search (elastic#82693) * add match_phrase_prefix clauses when using prefix search * add FTR tests # Conflicts: # src/core/server/saved_objects/service/lib/search_dsl/query_params.test.ts # src/core/server/saved_objects/service/lib/search_dsl/query_params.ts
Contributor
💚 Build SucceededMetrics [docs]
History
To update your PR or re-run it, just comment with: |
pgayvallet
added a commit
that referenced
this pull request
Nov 9, 2020
…using prefix search (#82693) (#82935) * SavedObjects search_dsl: add match_phrase_prefix clauses when using prefix search (#82693) * add match_phrase_prefix clauses when using prefix search * add FTR tests # Conflicts: # src/core/server/saved_objects/service/lib/search_dsl/query_params.test.ts # src/core/server/saved_objects/service/lib/search_dsl/query_params.ts * fix test file due to merge * fix files again
gmmorris
added a commit
to gmmorris/kibana
that referenced
this pull request
Nov 9, 2020
* master: Added `defaultActionMessage` to index threshold alert UI type definition (elastic#80936) [ILM] Migrate Delete phase and name field to Form Lib (elastic#82834) skip flaky suite (elastic#57426) [Alerting] adds an Run When field in the alert flyout to assign the action to an Action Group (elastic#82472) [APM] Expose APM event client as part of plugin contract (elastic#82724) [Logs UI] Fix errors during navigation (elastic#78319) Enable send to background in TSVB (elastic#82835) SavedObjects search_dsl: add match_phrase_prefix clauses when using prefix search (elastic#82693) [Ingest Manager] Unify install* under installPackage (elastic#82916)
phillipb
added a commit
to phillipb/kibana
that referenced
this pull request
Nov 10, 2020
…e-details-overlay * 'master' of github.com:elastic/kibana: (201 commits) Added `defaultActionMessage` to index threshold alert UI type definition (elastic#80936) [ILM] Migrate Delete phase and name field to Form Lib (elastic#82834) skip flaky suite (elastic#57426) [Alerting] adds an Run When field in the alert flyout to assign the action to an Action Group (elastic#82472) [APM] Expose APM event client as part of plugin contract (elastic#82724) [Logs UI] Fix errors during navigation (elastic#78319) Enable send to background in TSVB (elastic#82835) SavedObjects search_dsl: add match_phrase_prefix clauses when using prefix search (elastic#82693) [Ingest Manager] Unify install* under installPackage (elastic#82916) [Fleet] Make stream id unique in agent policy (elastic#82447) skip flaky suite (elastic#82915) skip flaky suite (elastic#75794) Copy `dateAsStringRt` to observability plugin (elastic#82839) [Maps] rename connected_components/map folder to mb_map (elastic#82897) [Security Solution] Fix EventsViewer DnD cypress tests (elastic#82619) [Security Solution] Adds logging and performance fan out API for threat/Indicator matching (elastic#82546) Implemented Alerting health status pusher by using task manager and status pooler for Kibana status plugins 'kibanahost/api/status' (elastic#79056) [APM] Adds new configuration 'xpack.apm.maxServiceEnvironments' (elastic#82090) Move single use function in line (elastic#82885) [ML] Add unsigned_long support to data frame analytics and anomaly detection (elastic#82636) ...
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix #5734 Fix #20242
See #5734 (comment) for more context about the implementation design.
getQueryParamsto add per-fieldmatch_phrase_prefixclauses when the user is performing a prefix search (*wildcard at the end of the query)getQueryParamsto no longer relies on mapping, and uses the SO type registry as single source of truth regarding declared typesChecklist
Release notes
Fix a bug causing searching for saved objects using special characters such as
*or-to not return any results.