Summary

I realized while doing some server API refactoring/testing that our MockRouter helper would fail/produce a false negative in the following example scenario:

export function registerSomeRoutes(...) {
  router.get(
    {
      path: '/api/app_search/example_one',
      validate: false,
    },
    enterpriseSearchRequestHandler.createRequest({
      path: '/as/example_one',
    })
  };

  router.get(
    {
      path: '/api/app_search/example_two',
      validate: false,
    },
    enterpriseSearchRequestHandler.createRequest({
      path: '/as/example_two',
    })
  };
}

Specifically, calling MockRouter.callRoute() would never actually call the 2nd router.get handler because of this line in the code:

Each router.get registration creates another array item in mock.calls, so the static [0] index meant only the 1st of each type of router method in a single registerSomeRoute function was ever getting called 😬

My solution/approach to this was adding a path param to the MockRouter initialization, and searching the array for the correct/specific route path. This has the benefit of being more explicit about exactly which route we're testing in our test code - I'll admit there have been a few times when I've been writing tests where I'm like, "how does this mock router know what route I'm testing??" so hopefully this helps answer that.

Checklist

Delete any items that are not applicable to this PR.

• Unit or functional tests were updated or added to match the most common scenarios