[Enterprise Search] Write tests groups routes#82669
Merged
scottybollinger merged 5 commits intoelastic:masterfrom Nov 5, 2020
Merged
[Enterprise Search] Write tests groups routes#82669scottybollinger merged 5 commits intoelastic:masterfrom
scottybollinger merged 5 commits intoelastic:masterfrom
Conversation
Since this is a migration of known good endpoints, these aren’t necessary.
Merged
1 task
Contributor
Author
|
@elasticmachine merge upstream |
This was removed in another commit and is no longer needed
Contributor
💚 Build SucceededMetrics [docs]
History
To update your PR or re-run it, just comment with: |
yakhinvadim
approved these changes
Nov 5, 2020
scottybollinger
added a commit
to scottybollinger/kibana
that referenced
this pull request
Nov 5, 2020
* Remove validation from groups route responses Since this is a migration of known good endpoints, these aren’t necessary. * Add tests for groups routes * Remove unused types * Remove registerWSGroupRoutes from groups test This was removed in another commit and is no longer needed Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
scottybollinger
added a commit
that referenced
this pull request
Nov 5, 2020
* Remove validation from groups route responses Since this is a migration of known good endpoints, these aren’t necessary. * Add tests for groups routes * Remove unused types * Remove registerWSGroupRoutes from groups test This was removed in another commit and is no longer needed Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds the tests for groups routes. Removed the validation of server response data as it is unnecessary.
Checklist