[SECURITY SOLUTIONS] Bring Async Search Back#82650
Merged
XavierM merged 6 commits intoelastic:masterfrom Nov 5, 2020
Merged
Conversation
patrykkopycinski
approved these changes
Nov 4, 2020
Contributor
patrykkopycinski
left a comment
There was a problem hiding this comment.
Thank you @XavierM 💪
angorayc
approved these changes
Nov 4, 2020
Contributor
💚 Build SucceededMetrics [docs]async chunks size
History
To update your PR or re-run it, just comment with: |
XavierM
added a commit
to XavierM/kibana
that referenced
this pull request
Nov 5, 2020
* bring async search back to the security solutions * remove id for timeline details searchStrategy * fix events count * fix total count * update units * update integration tests Co-authored-by: Angela Chuang <yi-chun.chuang@elastic.co> Co-authored-by: Patryk Kopycinski <contact@patrykkopycinski.com>
XavierM
added a commit
to XavierM/kibana
that referenced
this pull request
Nov 5, 2020
* bring async search back to the security solutions * remove id for timeline details searchStrategy * fix events count * fix total count * update units * update integration tests Co-authored-by: Angela Chuang <yi-chun.chuang@elastic.co> Co-authored-by: Patryk Kopycinski <contact@patrykkopycinski.com>
XavierM
added a commit
that referenced
this pull request
Nov 5, 2020
* bring async search back to the security solutions * remove id for timeline details searchStrategy * fix events count * fix total count * update units * update integration tests Co-authored-by: Angela Chuang <yi-chun.chuang@elastic.co> Co-authored-by: Patryk Kopycinski <contact@patrykkopycinski.com> Co-authored-by: Angela Chuang <yi-chun.chuang@elastic.co> Co-authored-by: Patryk Kopycinski <contact@patrykkopycinski.com>
XavierM
added a commit
that referenced
this pull request
Nov 5, 2020
* bring async search back to the security solutions * remove id for timeline details searchStrategy * fix events count * fix total count * update units * update integration tests Co-authored-by: Angela Chuang <yi-chun.chuang@elastic.co> Co-authored-by: Patryk Kopycinski <contact@patrykkopycinski.com> Co-authored-by: Angela Chuang <yi-chun.chuang@elastic.co> Co-authored-by: Patryk Kopycinski <contact@patrykkopycinski.com> Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
We thought that we were doing good by adding our own ID to the request so we can see which query was running in the dev tools. But by adding our own ID per request, we messed up the async search strategy because they are assuming that the id to be the actual id parameter returned from Elasticsearch. By changing the ID, we are breaking the way the poll work on the server-side strategy.
You can see it there -> https://github.com/elastic/kibana/blob/master/x-pack/plugins/data_enhanced/server/search/es_search_strategy.ts#L84