[Workplace Search] Refactor nav constants#82646
Merged
scottybollinger merged 5 commits intoelastic:masterfrom Nov 5, 2020
Merged
[Workplace Search] Refactor nav constants#82646scottybollinger merged 5 commits intoelastic:masterfrom
scottybollinger merged 5 commits intoelastic:masterfrom
Conversation
This was only needed locally in Groups but we can to store all nav constants in the global constants file
yakhinvadim
approved these changes
Nov 5, 2020
Contributor
Author
|
@elasticmachine merge upstream |
Contributor
💚 Build SucceededMetrics [docs]@kbn/optimizer bundle module count
async chunks size
History
To update your PR or re-run it, just comment with: |
Contributor
|
Friendly reminder: Looks like this PR hasn’t been backported yet. |
scottybollinger
added a commit
to scottybollinger/kibana
that referenced
this pull request
Nov 9, 2020
* Move NAV constants to top level This was only needed locally in Groups but we can to store all nav constants in the global constants file * Extract remaining nav constants * Fix links to NAV in routers * Use constant for path Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
scottybollinger
added a commit
that referenced
this pull request
Nov 9, 2020
* Move NAV constants to top level This was only needed locally in Groups but we can to store all nav constants in the global constants file * Extract remaining nav constants * Fix links to NAV in routers * Use constant for path Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This is a small refactor PR to clean up the navigation structure for Workplace Search. We began the process of extracting i18n constants to a constants file in a previous PR and this centralizes the nav constants in preparation for adding new components other than groups.