[test] Updates rollup test to allow incoming doc_count field mapper#82547
Merged
cjcenizal merged 2 commits intoelastic:masterfrom Nov 4, 2020
Merged
[test] Updates rollup test to allow incoming doc_count field mapper#82547cjcenizal merged 2 commits intoelastic:masterfrom
cjcenizal merged 2 commits intoelastic:masterfrom
Conversation
A doc_count field mapper was added in elastic/elasticsearch#64503 This is currently failing the ES promotion. After this promotion, we can go back and update this test to be an exact match on the body if we think that is the desired assertion. Signed-off-by: Tyler Smalley <tyler.smalley@elastic.co>
Contributor
|
Pinging @elastic/es-ui (Team:Elasticsearch UI) |
cjcenizal
approved these changes
Nov 4, 2020
Contributor
cjcenizal
left a comment
There was a problem hiding this comment.
LGTM, spotted one missing assertion.
Signed-off-by: Tyler Smalley <tyler.smalley@elastic.co>
Contributor
💚 Build SucceededMetrics [docs]
To update your PR or re-run it, just comment with: |
cjcenizal
added a commit
that referenced
this pull request
Nov 4, 2020
…82547) (#82554) * [test] Updates rollup test to allow incoming doc_count field mapper A doc_count field mapper was added in elastic/elasticsearch#64503 This is currently failing the ES promotion. After this promotion, we can go back and update this test to be an exact match on the body if we think that is the desired assertion. Signed-off-by: Tyler Smalley <tyler.smalley@elastic.co> Co-authored-by: Tyler Smalley <tyler.smalley@elastic.co>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A doc_count field mapper was added in elastic/elasticsearch#64503
This is currently failing the ES promotion. After this promotion, we can go back and update this test to be an exact match on the body if we think that is the desired assertion.