Put APM links into header action menu#82292
Merged
smith merged 33 commits intoelastic:masterfrom Nov 11, 2020
Merged
Conversation
Contributor
Author
|
retest |
sorenlouv
reviewed
Nov 6, 2020
sorenlouv
approved these changes
Nov 6, 2020
Contributor
sorenlouv
left a comment
There was a problem hiding this comment.
LGTM - just one question around useServiceName
Contributor
Author
|
@elasticmachine merge upstream |
Contributor
Author
|
@elasticmachine merge upstream |
shahzad31
reviewed
Nov 9, 2020
Contributor
Author
|
@sqren @shahzad31 I updated this to use the reverse portal. Please re-review. |
Contributor
Author
|
@elasticmachine merge upstream |
Contributor
💚 Build SucceededMetrics [docs]Module Count
Async chunks
Page load bundle
History
To update your PR or re-run it, just comment with: |
sorenlouv
approved these changes
Nov 10, 2020
smith
added a commit
to smith/kibana
that referenced
this pull request
Nov 11, 2020
smith
added a commit
that referenced
this pull request
Nov 11, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
APM
react-reverse-portalto mount it there.appMountParameters(which includeshistoryandsetHeaderActionMenu) in the APM and UX plugin contexts.isServiceMapEnabledcheck from the home tabs and make it a constant instead of a function.Before
After
Observability
setHelpExtensionmenuBefore
After
References #81954.