Skip to content

[deb/rpm] Set pid.file to /run/kibana/kibana.pid#82209

Merged
jbudz merged 6 commits intoelastic:masterfrom
jbudz:os/set-pid_file
Nov 9, 2020
Merged

[deb/rpm] Set pid.file to /run/kibana/kibana.pid#82209
jbudz merged 6 commits intoelastic:masterfrom
jbudz:os/set-pid_file

Conversation

@jbudz
Copy link
Copy Markdown
Contributor

@jbudz jbudz commented Oct 30, 2020

The parent folder is created by tmpfiles.d/kibana.conf

Testing:
/run/kibana/kibana.pid should be available somewhere between startup and listening on 5601. It won't be available immediately, it's a step in the platform startup.

The parent folder is created by tmpfiles.d/kibana.conf
@jbudz jbudz added Team:Operations Kibana-Operations Team v8.0.0 release_note:skip Skip the PR/issue when compiling release notes v7.11.0 labels Oct 30, 2020
@jbudz
Copy link
Copy Markdown
Contributor Author

jbudz commented Nov 2, 2020

@jbudz jbudz added the review label Nov 2, 2020
@jbudz jbudz marked this pull request as ready for review November 2, 2020 12:53
@jbudz jbudz requested a review from a team as a code owner November 2, 2020 12:53
@elasticmachine
Copy link
Copy Markdown
Contributor

Pinging @elastic/kibana-operations (Team:Operations)

@jbudz
Copy link
Copy Markdown
Contributor Author

jbudz commented Nov 4, 2020

@elasticmachine merge upstream

@jbudz
Copy link
Copy Markdown
Contributor Author

jbudz commented Nov 6, 2020

@elasticmachine merge upstream

@tylersmalley
Copy link
Copy Markdown
Member

LGTM - is this blocked on #82196?

@jbudz
Copy link
Copy Markdown
Contributor Author

jbudz commented Nov 9, 2020

@elasticmachine merge upstream

@jbudz
Copy link
Copy Markdown
Contributor Author

jbudz commented Nov 9, 2020

They should be okay. /var/run is symlinked to the same folder on our supported operating systems. I'll wait to merge both at the same time though to avoid any confusion.

@kibanamachine
Copy link
Copy Markdown
Contributor

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@jbudz jbudz merged commit 89547bc into elastic:master Nov 9, 2020
@jbudz jbudz deleted the os/set-pid_file branch November 9, 2020 16:08
jbudz added a commit that referenced this pull request Nov 9, 2020
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
@jbudz
Copy link
Copy Markdown
Contributor Author

jbudz commented Nov 9, 2020

7.x/7.11: 3aa3e81

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backported release_note:skip Skip the PR/issue when compiling release notes review Team:Operations Kibana-Operations Team v7.11.0 v8.0.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants