[Maps] Convert ES-sources to typescript#81951
Merged
thomasneirynck merged 77 commits intoelastic:masterfrom Nov 5, 2020
Merged
[Maps] Convert ES-sources to typescript#81951thomasneirynck merged 77 commits intoelastic:masterfrom
thomasneirynck merged 77 commits intoelastic:masterfrom
Conversation
nreese
reviewed
Nov 2, 2020
x-pack/plugins/maps/public/classes/sources/es_source/es_source.ts
Outdated
Show resolved
Hide resolved
x-pack/plugins/maps/public/classes/sources/es_source/es_source.ts
Outdated
Show resolved
Hide resolved
Closed
nreese
approved these changes
Nov 4, 2020
Contributor
nreese
left a comment
There was a problem hiding this comment.
Thanks for converting the sources to TS. This is a big chunk of logic
LGTM
code review
x-pack/plugins/maps/public/classes/sources/ems_tms_source/ems_tms_source.js
Outdated
Show resolved
Hide resolved
Contributor
💚 Build SucceededMetrics [docs]@kbn/optimizer bundle module count
async chunks size
page load bundle size
History
To update your PR or re-run it, just comment with: |
thomasneirynck
added a commit
to thomasneirynck/kibana
that referenced
this pull request
Nov 5, 2020
thomasneirynck
added a commit
that referenced
this pull request
Nov 5, 2020
This was referenced Nov 20, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Chore TS-conversion.
Checklist
For maintainers