[Security Solution][Detections] Fix error causing ml rules telemetry to be discarded#81945
Merged
rylnd merged 1 commit intoelastic:masterfrom Oct 28, 2020
Merged
[Security Solution][Detections] Fix error causing ml rules telemetry to be discarded#81945rylnd merged 1 commit intoelastic:masterfrom
rylnd merged 1 commit intoelastic:masterfrom
Conversation
A regression was introduced in elastic#74965 that caused an error to be thrown while collecting telemetry on ML jobs. Because such exceptions are caught and we degrade to zeroing out those counts, this one was not caught until manual testing of telemetry.
| if (ml) { | ||
| try { | ||
| const fakeRequest = {} as KibanaRequest; | ||
| const fakeRequest = { headers: {} } as KibanaRequest; |
Contributor
There was a problem hiding this comment.
Does this part need to be fixed as well?
https://github.com/elastic/kibana/blob/master/x-pack/plugins/security_solution/server/lib/detection_engine/signals/signal_rule_alert_type.ts#L212
Contributor
Author
There was a problem hiding this comment.
Good question! For now, it's only the modulesProvider that performs the additional headers check, the jobsProvider (and thus ML Rule execution) continues to function as expected.
FrankHassanabad
approved these changes
Oct 28, 2020
Contributor
FrankHassanabad
left a comment
There was a problem hiding this comment.
Took a look and it looks simple enough, just one question.
Contributor
💚 Build SucceededMetrics [docs]
To update your PR or re-run it, just comment with: |
This was referenced Oct 28, 2020
rylnd
added a commit
to rylnd/kibana
that referenced
this pull request
Oct 28, 2020
A regression was introduced in elastic#74965 that caused an error to be thrown while collecting telemetry on ML jobs. Because such exceptions are caught and we degrade to zeroing out those counts, this one was not caught until manual testing of telemetry.
rylnd
added a commit
that referenced
this pull request
Oct 29, 2020
A regression was introduced in #74965 that caused an error to be thrown while collecting telemetry on ML jobs. Because such exceptions are caught and we degrade to zeroing out those counts, this one was not caught until manual testing of telemetry.
rylnd
added a commit
that referenced
this pull request
Oct 29, 2020
A regression was introduced in #74965 that caused an error to be thrown while collecting telemetry on ML jobs. Because such exceptions are caught and we degrade to zeroing out those counts, this one was not caught until manual testing of telemetry.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A regression was introduced in #74965 that caused an error to be thrown while collecting telemetry on ML jobs. Because such exceptions are caught and we degrade to zeroing out those counts, this one was not caught until manual testing of telemetry.
For maintainers