[jenkins] disable CI metrics for temporary feature branches#81938
Merged
spalger merged 1 commit intoelastic:masterfrom Oct 28, 2020
Merged
Conversation
e41f747 to
968d538
Compare
968d538 to
5029a7a
Compare
Contributor
Author
|
Tested to make sure that https://kibana-ci.elastic.co/job/elastic+kibana+pipeline-pull-request/84408/execution/node/45/log/ |
Contributor
|
Pinging @elastic/kibana-operations (Team:Operations) |
brianseeders
approved these changes
Oct 28, 2020
Contributor
💚 Build SucceededMetrics [docs]
To update your PR or re-run it, just comment with: |
This was referenced Oct 28, 2020
spalger
added a commit
to spalger/kibana
that referenced
this pull request
Oct 28, 2020
…81938) Co-authored-by: spalger <spalger@users.noreply.github.com>
spalger
added a commit
to spalger/kibana
that referenced
this pull request
Oct 28, 2020
…81938) Co-authored-by: spalger <spalger@users.noreply.github.com>
spalger
added a commit
that referenced
this pull request
Oct 28, 2020
spalger
added a commit
that referenced
this pull request
Oct 28, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With PRs like #81766, the CI metrics are marking the CI report as failed because the target branch is not getting baselines captured for it. We want to make it possible for these PRs to have metrics, but not required, and to do that the plan is to determine if the target branch for the PR matches the
"branch"field in the rootpackage.jsonfile. When these don't match then CI metrics will become optional and CI report comments will not report as failures when the baseline metrics can't be determined.