[ML] Add annotation markers to time series brush area to indicate annotations exist outside of selected range#81490
Merged
qn895 merged 23 commits intoelastic:masterfrom Nov 4, 2020
Conversation
…http getAnnotations, add new annotation markers in brush timeline
…ove this.previousShowAnnotations
Member
Author
|
@elasticmachine merge upstream |
Contributor
|
Pinging @elastic/ml-ui (:ml) |
darnautov
reviewed
Oct 27, 2020
x-pack/plugins/ml/public/application/timeseriesexplorer/timeseriesexplorer.js
Outdated
Show resolved
Hide resolved
x-pack/plugins/ml/public/application/timeseriesexplorer/timeseriesexplorer.js
Outdated
Show resolved
Hide resolved
...ins/ml/public/application/timeseriesexplorer/components/timeseries_chart/timeseries_chart.js
Outdated
Show resolved
Hide resolved
...ins/ml/public/application/timeseriesexplorer/components/timeseries_chart/timeseries_chart.js
Outdated
Show resolved
Hide resolved
…-markers-in-context-brush-area
…-markers-in-context-brush-area
…-markers-in-context-brush-area
darnautov
reviewed
Nov 3, 2020
x-pack/plugins/ml/public/application/timeseriesexplorer/timeseriesexplorer.js
Outdated
Show resolved
Hide resolved
darnautov
reviewed
Nov 3, 2020
...application/timeseriesexplorer/components/timeseries_chart/timeseries_chart_with_tooltip.tsx
Outdated
Show resolved
Hide resolved
Contributor
peteharverson
left a comment
There was a problem hiding this comment.
I like the way the annotations are shown for the full chart area! Left a couple of comments about refining the query used to load the annotations.
...application/timeseriesexplorer/components/timeseries_chart/timeseries_chart_with_tooltip.tsx
Outdated
Show resolved
Hide resolved
...application/timeseriesexplorer/components/timeseries_chart/timeseries_chart_with_tooltip.tsx
Outdated
Show resolved
Hide resolved
…-markers-in-context-brush-area
peteharverson
approved these changes
Nov 4, 2020
Contributor
peteharverson
left a comment
There was a problem hiding this comment.
Tested latest changes and LGTM.
…-markers-in-context-brush-area
Contributor
💚 Build SucceededMetrics [docs]@kbn/optimizer bundle module count
async chunks size
History
To update your PR or re-run it, just comment with: |
ryankeairns
approved these changes
Nov 4, 2020
| // context annotation marker | ||
| .mlContextAnnotationRect { | ||
| stroke: $euiColorFullShade; | ||
| stroke-width: $mlAnnotationBorderWidth; |
Contributor
There was a problem hiding this comment.
For what it's worth, there are 1px $euiBorderWidthThin and 2px $euiBorderWidthThick variables, if you're interested in using them here.
Member
Author
There was a problem hiding this comment.
Thanks for looking it over 🙏 I think I'll keep mlAnnotationBorderWidth here since it's used for other parts as well but good to know we do have those variables available.
qn895
added a commit
to qn895/kibana
that referenced
this pull request
Nov 4, 2020
…otations exist outside of selected range (elastic#81490) Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
gmmorris
added a commit
to gmmorris/kibana
that referenced
this pull request
Nov 5, 2020
* master: (127 commits) [ILM] Fix breadcrumbs (elastic#82594) [UX]Swap env filter with percentile (elastic#82246) Add platform's missing READMEs (elastic#82268) [Discover] Adding uiMetric to track Visualize link click (elastic#82344) [Search] Add used index pattern name to the search agg error field (elastic#82604) improve client-side SO client get pooling (elastic#82603) [Security Solution] Unskips Overview tests (elastic#82459) Embeddables/migrations (elastic#82296) [Enterprise Search] Refactor product server route registrations to their own files/folders (elastic#82663) Moving reinstall function outside of promise.all (elastic#82672) Load choropleth layer correctly (elastic#82628) Master backport elastic#81233 (elastic#82642) [Fleet] Allow snake cased Kibana assets (elastic#77515) Reduce saved objects authorization checks (elastic#82204) [data.search] Add request handler context and asScoped pattern (elastic#80775) [ML] Fixes formatting of fields in index data visualizer (elastic#82593) Usage collector readme (elastic#82548) [Lens] Visualization validation and better error messages (elastic#81439) [ML] Add annotation markers to time series brush area to indicate annotations exist outside of selected range (elastic#81490) chore(NA): install microdnf in UBI docker build only (elastic#82611) ...
25 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes #54025 by adding markers for annotations in the time series brush area to show and that annotations exist outside of the selected, visible range