Skip to content

[Discover] Unskip functional sidebar test#81188

Merged
kertal merged 4 commits intoelastic:masterfrom
kertal:kertal-pr-2020-10-20-discover-unskip-sidebar
Nov 3, 2020
Merged

[Discover] Unskip functional sidebar test#81188
kertal merged 4 commits intoelastic:masterfrom
kertal:kertal-pr-2020-10-20-discover-unskip-sidebar

Conversation

@kertal
Copy link
Copy Markdown
Member

@kertal kertal commented Oct 20, 2020 •
edited
Loading

Summary

Confirmed to be flaky by using the flaky test runner https://kibana-ci.elastic.co/job/kibana+flaky-test-suite-runner/912/, which failed with the following screen

image

It's checking for the sidebar filter to be hidden ... in the screenshot it's hidden, that's what's happening in the logs:

[00:16:03]               └-> "before all" hook
[00:16:03]               └-> should reveal and hide the filter form when the toggle is clicked
[00:16:03]                 └-> "before each" hook: global before each
[00:16:03]                 │ debg TestSubjects.click(toggleFieldFilterButton)
[00:16:03]                 │ debg Find.clickByCssSelector('[data-test-subj="toggleFieldFilterButton"]') with timeout=10000
[00:16:03]                 │ debg Find.findByCssSelector('[data-test-subj="toggleFieldFilterButton"]') with timeout=10000
[00:16:03]                 │ debg TestSubjects.exists(filterSelectionPanel)
[00:16:03]                 │ debg Find.existsByDisplayedByCssSelector('[data-test-subj="filterSelectionPanel"]') with timeout=120000
[00:16:03]                 │ debg TestSubjects.click(toggleFieldFilterButton)
[00:16:03]                 │ debg Find.clickByCssSelector('[data-test-subj="toggleFieldFilterButton"]') with timeout=10000
[00:16:03]                 │ debg Find.findByCssSelector('[data-test-subj="toggleFieldFilterButton"]') with timeout=10000
[00:16:03]                 │ debg TestSubjects.missingOrFail(filterSelectionPanel)
[00:16:03]                 │ debg TestSubjects.waitForHidden(filterSelectionPanel)
[00:16:03]                 │ debg TestSubjects.find(filterSelectionPanel)
[00:16:03]                 │ debg Find.findByCssSelector('[data-test-subj="filterSelectionPanel"]') with timeout=10000
[00:16:05]                 │ debg Find.waitForElementHidden with timeout=2500
[00:16:05]                 │ info Taking screenshot "/dev/shm/workspace/kibana/test/functional/screenshots/failure/discover app discover sidebar field filtering should reveal and hide the filter form when the toggle is clicked.png"

This PR fixes this flakiness, but also the flaky tests runner uncovers another flakiness by a different test:

https://kibana-ci.elastic.co/job/kibana+flaky-test-suite-runner/925/

Here discover app discover doc table add and remove columns should remove columns from the table is failing in a flaky way, started #82430 for this

Fixes #80914

Checklist

Delete any items that are not applicable to this PR.

@kertal kertal self-assigned this Oct 20, 2020
@kertal kertal added the Feature:Discover Discover Application label Oct 20, 2020
@kibanamachine
Copy link
Copy Markdown
Contributor

kibanamachine commented Nov 2, 2020

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@kertal kertal added the Team:Visualizations Team label for Lens, elastic-charts, Graph, legacy editors (TSVB, Visualize, Timelion) t// label Nov 3, 2020
@kertal kertal requested a review from spalger November 3, 2020 13:37
@kertal kertal added the release_note:skip Skip the PR/issue when compiling release notes label Nov 3, 2020
@kertal kertal requested a review from mistic November 3, 2020 13:37
@kertal kertal marked this pull request as ready for review November 3, 2020 15:13
@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Nov 3, 2020

Pinging @elastic/kibana-app (Team:KibanaApp)

@spalger
Copy link
Copy Markdown
Contributor

spalger commented Nov 3, 2020

This PR fixes this flakiness, but also the flaky tests runner uncovers another flakiness by a different test:

Sounds like we can't merge this until the other flakiness is fixed too. Sounds like we should merge the two PRs because we can't unskip the suite until it's not flaky.

@kertal
Copy link
Copy Markdown
Member Author

kertal commented Nov 3, 2020

This PR fixes this flakiness, but also the flaky tests runner uncovers another flakiness by a different test:

Sounds like we can't merge this until the other flakiness is fixed too. Sounds like we should merge the two PRs because we can't unskip the suite until it's not flaky.

@spalger The new flaky ones are in a different file (_doc_table.ts), but in the same group, that's why I couldn't get a flaky test without failures (ran the whole group)

spalger
spalger approved these changes Nov 3, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@spalger spalger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kertal kertal merged commit 82ee8ae into elastic:master Nov 3, 2020
kertal added a commit to kertal/kibana that referenced this pull request Nov 3, 2020
@kertal
[Discover] Unskip functional sidebar test (elastic#81188)
641b6b3
@kertal kertal mentioned this pull request Nov 3, 2020
Merged
kertal added a commit that referenced this pull request Nov 3, 2020
@kertal
[Discover] Unskip functional sidebar test (#81188) (#82454)
a0016ce
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mistic mistic Awaiting requested review from mistic

1 more reviewer

@spalger spalger spalger approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@kertal kertal

Labels

Feature:Discover Discover Application release_note:skip Skip the PR/issue when compiling release notes Team:Visualizations Team label for Lens, elastic-charts, Graph, legacy editors (TSVB, Visualize, Timelion) t// v7.11.0 v8.0.0

Projects

None yet

Milestone

No milestone

4 participants

@kertal @kibanamachine @elasticmachine @spalger