Add tsconfig for url_forwarding by smith · Pull Request #81177 · elastic/kibana

smith · 2020-10-20T14:51:09Z

Also:

Add missing entry in tsconfig.refs.json for kibana_legacy, as a follow-up to Add TS config for kibana_legacy #80992.
Add missing .d.ts files for kibana_legacy.
Explicitly import MockedKeys and DeeplyMockedKeys.
Add missing exclusions in x-pack/tsconfig.json.
Alphabetize lists.

References #80508
References #81003

Also add missing pieces to kibana_react, as a follow-up to elastic#80992. References elastic#80508 References elastic#81003

smith · 2020-10-20T14:54:22Z

I had to add a bunch of the missing exports to new .d.ts files in kibana_legacy. The errors didn't show up when. I ran tsc in kibana_legacy or in the CI checks in the top level.

When I run npx tsc from url_forwarding after adding these changes I'm still getting a bunch of errors from core:

../../core/target/types/public/chrome/chrome_service.mock.d.ts:5:32 - error TS2304: Cannot find name 'DeeplyMockedKeys'.

5     createStartContract: () => DeeplyMockedKeys<InternalChromeStart>;
                                 ~~~~~~~~~~~~~~~~

../../core/target/types/public/mocks.d.ts:26:17 - error TS2304: Cannot find name 'DeeplyMockedKeys'.

26         chrome: DeeplyMockedKeys<import("./chrome").InternalChromeStart>;
                   ~~~~~~~~~~~~~~~~

../../core/target/types/public/mocks.d.ts:30:24 - error TS2304: Cannot find name 'MockedKeys'.

30         notifications: MockedKeys<import(".").NotificationsStart>;
                          ~~~~~~~~~~

../../core/target/types/public/mocks.d.ts:31:19 - error TS2304: Cannot find name 'DeeplyMockedKeys'.

31         overlays: DeeplyMockedKeys<import(".").OverlayStart>;
                     ~~~~~~~~~~~~~~~~

../../core/target/types/public/mocks.d.ts:40:20 - error TS2304: Cannot find name 'MockedKeys'.

40     notifications: MockedKeys<import(".").NotificationsSetup>;
                      ~~~~~~~~~~

../../core/target/types/public/mocks.d.ts:50:13 - error TS2304: Cannot find name 'DeeplyMockedKeys'.

50     chrome: DeeplyMockedKeys<import("./chrome").InternalChromeStart>;
               ~~~~~~~~~~~~~~~~

../../core/target/types/public/mocks.d.ts:54:20 - error TS2304: Cannot find name 'MockedKeys'.

54     notifications: MockedKeys<import(".").NotificationsStart>;
                      ~~~~~~~~~~

../../core/target/types/public/mocks.d.ts:55:15 - error TS2304: Cannot find name 'DeeplyMockedKeys'.

55     overlays: DeeplyMockedKeys<import(".").OverlayStart>;
                 ~~~~~~~~~~~~~~~~

../../core/target/types/public/notifications/notifications_service.mock.d.ts:5:32 - error TS2304: Cannot find name 'MockedKeys'.

5     createSetupContract: () => MockedKeys<NotificationsSetup>;
                                 ~~~~~~~~~~

../../core/target/types/public/notifications/notifications_service.mock.d.ts:6:32 - error TS2304: Cannot find name 'MockedKeys'.

6     createStartContract: () => MockedKeys<NotificationsStart>;
                                 ~~~~~~~~~~

../../core/target/types/public/overlays/overlay_service.mock.d.ts:5:32 - error TS2304: Cannot find name 'DeeplyMockedKeys'.

5     createStartContract: () => DeeplyMockedKeys<OverlayStart>;
                                 ~~~~~~~~~~~~~~~~

../../core/target/types/server/elasticsearch/elasticsearch_service.d.ts:4:33 - error TS2307: Cannot find module '../audit_trail' or its corresponding type declarations.

4 import { AuditTrailStart } from '../audit_trail';
                                  ~~~~~~~~~~~~~~~~

../../core/target/types/server/elasticsearch/legacy/cluster_client.d.ts:2:32 - error TS2307: Cannot find module '../../audit_trail' or its corresponding type declarations.

2 import { AuditorFactory } from '../../audit_trail';
                                 ~~~~~~~~~~~~~~~~~~~

../../core/target/types/server/elasticsearch/legacy/scoped_cluster_client.d.ts:1:25 - error TS2307: Cannot find module '../../audit_trail' or its corresponding type declarations.

1 import { Auditor } from '../../audit_trail';
                          ~~~~~~~~~~~~~~~~~~~

../../core/target/types/server/index.d.ts:34:59 - error TS2307: Cannot find module './audit_trail' or its corresponding type declarations.

34 import { Auditor, AuditTrailSetup, AuditTrailStart } from './audit_trail';
                                                             ~~~~~~~~~~~~~~~

../../core/target/types/server/index.d.ts:39:74 - error TS2307: Cannot find module './audit_trail' or its corresponding type declarations.

39 export { AuditableEvent, Auditor, AuditorFactory, AuditTrailSetup } from './audit_trail';
                                                                            ~~~~~~~~~~~~~~~

../../core/target/types/server/internal_types.d.ts:14:50 - error TS2307: Cannot find module './audit_trail' or its corresponding type declarations.

14 import { AuditTrailSetup, AuditTrailStart } from './audit_trail';
                                                    ~~~~~~~~~~~~~~~


Found 17 errors.

Do I have an incorrect path or missing compiler option or do we need to add missing .d.ts for all the projects that reference them?

The files failing with MockedKeys and DeeplyMockedKeys have /// <reference types="jest" />. There's a jest.d.ts in x-pack, does the contents for that need to be moved/copied to the root typings?

mshustov · 2020-10-20T15:47:12Z

I don't see any errors for ./node_modules/.bin/tsc -b src/plugins/kibana_legacy/tsconfig.json
I added the next tsconfig.json for url_forwarding :

{
  "extends": "../../../tsconfig.base.json",
  "compilerOptions": {
    "composite": true,
    "outDir": "./target/types",
    "emitDeclarationOnly": true,
    "declaration": true,
    "declarationMap": true
  },
  "include": ["../../../typings/**/*", "public/**/*"],
  "references": [{
    "path": "../../core/tsconfig.json"
  }, {
    "path": "../kibana_legacy/tsconfig.json"
  }]
}

and can see only the next errors when run ./node_modules/.bin/tsc -b src/plugins/url_forwarding/tsconfig.json

src/plugins/kibana_legacy/target/types/public/angular/index.d.ts:1:39 - error TS7016: Could not find a declaration file for module './promises'. '/Users/mikhailshustov/work/kibana/src/plugins/kibana_legacy/public/angular/promises.js' implicitly has an 'any' type.

1 export { PromiseServiceCreator } from './promises';
                                        ~~~~~~~~~~~~

src/plugins/kibana_legacy/target/types/public/angular/index.d.ts:2:37 - error TS7016: Could not find a declaration file for module './watch_multi'. '/Users/mikhailshustov/work/kibana/src/plugins/kibana_legacy/public/angular/watch_multi.js' implicitly has an 'any' type.

2 export { watchMultiDecorator } from './watch_multi';
                                      ~~~~~~~~~~~~~~~

src/plugins/kibana_legacy/target/types/public/angular/index.d.ts:4:84 - error TS7016: Could not find a declaration file for module './kbn_top_nav'. '/Users/mikhailshustov/work/kibana/src/plugins/kibana_legacy/public/angular/kbn_top_nav.js' implicitly has an 'any' type.

4 export { createTopNavDirective, createTopNavHelper, loadKbnTopNavDirectives } from './kbn_top_nav';
                                                                                     ~~~~~~~~~~~~~~~

src/plugins/kibana_legacy/target/types/public/utils/index.d.ts:2:44 - error TS7016: Could not find a declaration file for module './kbn_accessible_click'. '/Users/mikhailshustov/work/kibana/src/plugins/kibana_legacy/public/utils/kbn_accessible_click.js' implicitly has an 'any' type.

2 export { KbnAccessibleClickProvider } from './kbn_accessible_click';
                                             ~~~~~~~~~~~~~~~~~~~~~~~~

src/plugins/kibana_legacy/target/types/public/utils/index.d.ts:4:45 - error TS7016: Could not find a declaration file for module './register_listen_event_listener'. '/Users/mikhailshustov/work/kibana/src/plugins/kibana_legacy/public/utils/register_listen_event_listener.js' implicitly has an 'any' type.

4 export { registerListenEventListener } from './register_listen_event_listener';
                                              ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

@smith I'm not sure what tsconfig npx tsc uses

smith · 2020-10-20T18:28:38Z

@restrry ok the errors you saw are the ones I'm fixing in this PR by adding the .d.ts files to kibana_legacy. The ones I'm seeing in core must be because of something else. I assumed running tsc from a directory would default to ./tsconfig.json but I'll make sure to run it with the config explicitly from now on. Thanks!

…rding

smith · 2020-10-27T14:47:26Z

@elasticmachine merge upstream

Currently blocked by elastic#81177 because it fails on `MockedKeys/DeeplyMockedKeys`

kibanamachine · 2020-10-27T16:55:18Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request
Commit: 8651897

Metrics [docs]

✅ unchanged

History

💚 Build #83962 succeeded 24ce1c0
💚 Build #83757 succeeded ad99ae8
💚 Build #83679 succeeded f2d6374
💔 Build #83660 failed 7bd1e8f
💔 Build #83462 failed 3d39bc4

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

flash1293

Seems like a lot is going on in this PR and I don't understand half of it - focused on the KibanaApp changes, those LGTM (only adding additional types). Left a nit about a type that can be improved, but as there are many more missing and these utilities are deprecated anyway it's low priority.

flash1293 · 2020-10-27T16:56:57Z

src/plugins/kibana_legacy/public/angular/kbn_top_nav.d.ts

+  IController
+>>;
+export const createTopNavHelper: (
+  options: unknown


nit: This is NavigationPublicPluginStart['ui']

Thanks for that. I think I'll leave it since it's not widely used and I wanted to be as generic as possible since I'm not familiar with the code.

Also add missing pieces to kibana_react, as a follow-up to elastic#80992. References elastic#80508 References elastic#81003 # Conflicts: # tsconfig.json

Also add missing pieces to kibana_react, as a follow-up to #80992. References #80508 References #81003

…kibana into task-manager/lost-connectivity * 'task-manager/lost-connectivity' of github.com:gmmorris/kibana: skips overview tests (elastic#81877) [Security Solution][Case] Fix connector's labeling (elastic#81824) [Maps] Fix EMS test (elastic#81856) [Security Solutions][Detections] - Fix bug, last response not showing for disabled rules (elastic#81783) skip flaky suite (elastic#81853) Add tsconfig for url_forwarding (elastic#81177) skip flaky suite (elastic#81844) check for server enabled (elastic#81818) [Seurity Solution][Case] Create case plugin client (elastic#81018) [Security Solutions][Detection Engine] Changes wording for threat matches and rules (elastic#81334) [Security Solution] critical pref bug with browser fields reducer

Add tsconfig for url_forwarding

0964a15

Also add missing pieces to kibana_react, as a follow-up to elastic#80992. References elastic#80508 References elastic#81003

smith added 2 commits October 21, 2020 10:47

Merge remote-tracking branch 'upstream/master' into nls/tpr_url_forwa…

2cd7bea

…rding

Add additional files

c4410d9

smith mentioned this pull request Oct 21, 2020

[APM] Migrate Kibana plugins (that depend on APM) to TS project references #81003

Closed

smith added 8 commits October 22, 2020 10:24

Add tsconfig ref to x-pack

c03408c

Merge remote-tracking branch 'upstream/master' into nls/tpr_url_forwa…

b2aab5c

…rding

add url_forwarding to xpack

064a9e3

remove dup deply

58c1085

Add back typings

4f9ea68

Remove import of deeplymockedkeys

6b0c78b

revert a change

705a25b

Merge remote-tracking branch 'upstream/master' into nls/tpr_url_forwa…

93b0928

…rding

mshustov mentioned this pull request Oct 22, 2020

explicitly export core mock types #81527

Closed

smith added 6 commits October 22, 2020 15:26

export deeply mocked keys

3d39bc4

Merge remote-tracking branch 'upstream/master' into nls/tpr_url_forwa…

c788f62

…rding

Fix kibana legacy angular types

7bd1e8f

Add another missing angular

f2d6374

Add missing refs to xpack

f0209a9

Merge remote-tracking branch 'upstream/master' into nls/tpr_url_forwa…

ad99ae8

…rding

smith marked this pull request as ready for review October 26, 2020 22:55

smith requested a review from a team October 26, 2020 22:55

smith requested a review from a team as a code owner October 26, 2020 22:55

smith added release_note:skip Skip the PR/issue when compiling release notes v7.11.0 v8.0.0 labels Oct 26, 2020

mshustov approved these changes Oct 27, 2020

View reviewed changes

Merge branch 'master' into nls/tpr_url_forwarding

24ce1c0

smith added a commit to smith/kibana that referenced this pull request Oct 27, 2020

Add TS project references for inspector

8324d7d

Currently blocked by elastic#81177 because it fails on `MockedKeys/DeeplyMockedKeys`

smith mentioned this pull request Oct 27, 2020

Add TS project references for inspector #81792

Merged

remove unnecessary excludes from x-pack

8651897

flash1293 approved these changes Oct 27, 2020

View reviewed changes

smith merged commit d1827dc into elastic:master Oct 27, 2020

smith deleted the nls/tpr_url_forwarding branch October 27, 2020 20:18

smith mentioned this pull request Oct 27, 2020

[7.x] Add tsconfig for url_forwarding (#81177) #81854

Merged

smith added a commit to smith/kibana that referenced this pull request Oct 27, 2020

Add tsconfig for url_forwarding (elastic#81177)

454f9e9

Also add missing pieces to kibana_react, as a follow-up to elastic#80992. References elastic#80508 References elastic#81003 # Conflicts: # tsconfig.json

smith added a commit that referenced this pull request Oct 27, 2020

Add tsconfig for url_forwarding (#81177) (#81854)

c9bd1a3

Also add missing pieces to kibana_react, as a follow-up to #80992. References #80508 References #81003

TinaHeiligers mentioned this pull request Nov 4, 2020

[Usage Collection & Telemetry] Migrate to TS project references #81017

Closed

7 tasks

TinaHeiligers mentioned this pull request Jan 26, 2021

[Meta] Migrate plugins to TS references for es_ui CODEOWNERS plugins #89321

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add tsconfig for url_forwarding#81177

Add tsconfig for url_forwarding#81177
smith merged 19 commits intoelastic:masterfrom
smith:nls/tpr_url_forwarding

smith commented Oct 20, 2020 •

edited

Loading

Uh oh!

smith commented Oct 20, 2020 •

edited

Loading

Uh oh!

mshustov commented Oct 20, 2020 •

edited

Loading

Uh oh!

smith commented Oct 20, 2020

Uh oh!

smith commented Oct 27, 2020

Uh oh!

kibanamachine commented Oct 27, 2020

Uh oh!

flash1293 left a comment

Uh oh!

flash1293 Oct 27, 2020

Uh oh!

smith Oct 27, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

smith commented Oct 20, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

smith commented Oct 20, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mshustov commented Oct 20, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

smith commented Oct 20, 2020

Uh oh!

smith commented Oct 27, 2020

Uh oh!

kibanamachine commented Oct 27, 2020

💚 Build Succeeded

Metrics [docs]

History

Uh oh!

flash1293 left a comment

Choose a reason for hiding this comment

Uh oh!

flash1293 Oct 27, 2020

Choose a reason for hiding this comment

Uh oh!

smith Oct 27, 2020

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

smith commented Oct 20, 2020 •

edited

Loading

smith commented Oct 20, 2020 •

edited

Loading

mshustov commented Oct 20, 2020 •

edited

Loading