Tagcloud by thomasneirynck · Pull Request #8104 · elastic/kibana

thomasneirynck · 2016-08-26T16:29:40Z

moving tagcloud PR (#6975). resolved merge conflicts, checking if it runs in CI

thomasneirynck · 2016-08-26T20:51:32Z

jenkins, test this.

thomasneirynck · 2016-08-29T15:15:41Z

This is now running again. I added it to the core-vis library, so it loads on startup without additional plugin installation commands.

verify/extend existing test suite (failing build!)
- test suite not running properly. many tests skipped.
- failing tests
error handling (empty ES responses throw unhandled errors)

To test this:

run npm install
easiest setup is choosing a foo.raw field from a logstash index in the tags aggregation section

small UI changes:

@stormpython FYI: apart from resolving merge conflicts, and some reshuffling of the code so it gets loaded on startup, this worked pretty much out of the box. Thanks!

markharwood · 2016-08-31T17:13:31Z

If using significant terms is there an option to size text by the significance score?
Popularity != significance e.g. the circle sizes in this example visualization are sized by level-of-change not popularity

stormpython · 2016-08-31T17:44:55Z

src/core_plugins/tag_cloud/public/lib/cloud_controller.js

@markharwood @thomasneirynck
here is where the size for the text is set.

thomasneirynck · 2016-08-31T19:50:12Z

@markharwood not sure. Have you seen this in any other Kibana visualizations? The tags are sized according to the aggregation-value. So e.g. counts, averages, ... I'm not quite sure if we are lifting out the significance score in any other viz either.

markharwood · 2016-08-31T20:31:59Z

here is where the size for the text is set.

I'm not sure what metricsAgg is picking up as the value - the score or the doc count?
If your search is for bird flu doc count will tell you that the is most popular while significance score will tell you h5n1 is most interesting.

I'm not quite sure if we are lifting out the significance score in any other viz either.

We use it as the sort order for selecting which terms to surface but don't illustrate the magnitude of the score. This is what the diagram I linked to illustrates in terms of movement from a background frequency. It's possibly a little hard for users to interpret but the sizing of words in tag clouds is easier to grok and should be based on score not doc_count.

stormpython · 2016-08-31T23:25:15Z

@markharwood @thomasneirynck its picking up the doc count. If I recall correctly, metricsAgg is from the Metrics dropdown that is selected, which defaults to count. I am not sure if significance score is an option in the Metrics dropdown. But if its added for significant terms, then it should just work out of the box.

thomasneirynck · 2016-09-12T13:49:45Z

for reviewers, this is an early check-in, so this will be revised most certainly.

For now, mainly looking for functional feedback: do the options in the forms make sense, does it work as expected, what is missing/what should be added, ...

jbudz · 2016-09-12T16:37:29Z

Awesome, this looks really good. Not looking at the code but a few notes while using it:

The current font doesn't match kibana's font family
The arc input is handy but also it can be difficult to reset it back to defaults
I'm not sure if it's possible with the current plugin, but word positioning isn't deterministic. On page refresh I can see it render twice, resize, etc moving the words around

thomasneirynck · 2016-09-12T20:25:11Z

@jbudz

about the determinism of word positioning. Agreed, that's a problem. At this point,I'm not quite sure how to resolve this. The problem is that at each visualization rendering, the entire visualization gets torn down and recreated (the layout algo indeed has some random elements). This is the standard flow of the visualization app. Ideally, there's an update hook, that when the visualizations options change (and the data remains the same), the same order can be reused. To be investigated.It'd be nice to incorporate this.

(thanks for the bug list, I'll address these)

cjcenizal · 2016-09-15T15:43:07Z

Great work on this @thomasneirynck ! And thanks for coming back and offering guidance @stormpython . :)

A few comments:

Difficulty in relating input to output

I had a bit of a hard time understanding how my aggregations were impacting the tag cloud. This is a problem I have with all visualizations, but it seems a little more acute here because of the "volatile" nature of the tag cloud. This may be due to its non-determinism. It may also be due to the fact that tag clouds represent data in less-organized way, so it's more difficult for me to pin down specific relationships between different parts of the vis (as opposed to say, a bar chart).

Font style and weight

Maybe we can remove the oblique font style, as well as the bolder and lighter weight options. They didn't seem to have a noticeable impact on the way the vis appeared.

Orientations control

Maybe we can brainstorm on ways to make this control clearer? I don't quite understand how this control works. Possibly we could solve this with better labeling/help text.

The usefulness of tag clouds

Here are some useful articles I found on the pros and cons of tag clouds:

Personally, I don't think they are very useful but I'm sure that we have users who would like to use them. So I think this is a good addition to our product, and I think our users will appreciate it!

thomasneirynck · 2016-09-16T14:37:33Z

@cjcenizal thanks so much for the careful and measured feedback, I love that.

orientations control: this is something I experimented with, so it's good to have other people try it out. I wanted to avoid the ability of users to put in a conflicting feedback, and not have to deal with 3 separate controls. Mixed results, so let's talk ;)
usefulness: I think word clouds are good as an infographic. Something that's a little whimsical, and allows presenters to make part of their story 'pop'. It has a narrow range of usefulness. It is not good as a data visualization, in that you can only make the crudest quantitative inference about the underlying data. So I'd tend to agree with the first two links, who balance both ends in the same way. I think the message from the 3rd link is a little too glib; never say never. It is also a critique of using too simple of an underlying textual analysis (word counting as some sort of indication of relevance), that would reflect in any visualization using a term aggregation in Kibana.

cjcenizal

Had a very superficial glance-through and had a couple suggestions. I'll review more thoroughly once you're done.

cjcenizal · 2016-10-17T15:23:54Z

src/core_plugins/tag_cloud/public/arcinput_directive.js

Can you elaborate on this comment?

sorry, that file needs to be deleted since it is the directive for the UI-input we'll remove. it was a mistake to check this in, let alone the garbled language

cjcenizal · 2016-10-17T15:25:18Z

src/core_plugins/tag_cloud/public/vis/components/layout/layout.js

return `translate(${d.dx},${d.dy})`;

jbudz · 2016-10-18T14:31:26Z

when you get a chance can we rebase this?

thomasneirynck · 2016-10-22T01:49:58Z

Latest e220ae4.

removed gridded layouts. This is only relevant when we have multiple clouds. For now, that's not necessary.
removed circular angle selector, and added simplified orientation selection: single, right angles, multiple angles.
trimmed code down, simplified directory structure
added animations between different clouds. this helps avoid nasty flickers as well.

thomasneirynck · 2016-10-24T18:14:53Z

junk/clinton.json

please ignore these for know. I used these for testing internally. will need to remove them.

thomasneirynck · 2016-11-21T16:18:46Z

for reference; using new double-ended slider for font-size selection:

jbudz · 2016-11-21T16:27:32Z

Thoughts on adding a margin?

thomasneirynck · 2016-11-21T16:28:18Z

@jbudz ow that looks bad. yes, will add margin

thomasneirynck · 2016-11-21T17:33:26Z

jenkins, test this

ppisljar · 2016-11-21T17:58:54Z

@cjcenizal do you want to take a look at the slider ?

ppisljar · 2016-11-21T21:23:59Z

LGTM

this was a very early review. Code style issue + UI func addressed since.

Backports PR #8104 **Commit 1:** tagcloud squashed * Original sha: 1282011 * Authored by Thomas Neirynck <thomas@elastic.co> on 2016-11-18T21:08:29Z **Commit 2:** ensure tags are not turned upside down * Original sha: 68e09f4 * Authored by Thomas Neirynck <thomas@elastic.co> on 2016-11-21T03:43:41Z **Commit 3:** remove unnecessary background * Original sha: dba79b8 * Authored by Thomas Neirynck <thomas@elastic.co> on 2016-11-21T03:55:54Z **Commit 4:** add option to hide the label * Original sha: 7f32544 * Authored by Thomas Neirynck <thomas@elastic.co> on 2016-11-21T04:08:45Z **Commit 5:** use double-ende slider for font-size selection * Original sha: 00c9ea8 * Authored by Thomas Neirynck <thomas@elastic.co> on 2016-11-21T15:26:14Z **Commit 6:** give slider some more space * Original sha: b282084 * Authored by Thomas Neirynck <thomas@elastic.co> on 2016-11-21T16:38:55Z **Commit 7:** do not allow 0-sized tags * Original sha: 42bbc39 * Authored by Thomas Neirynck <thomas@elastic.co> on 2016-11-21T16:44:26Z **Commit 8:** fix typo * Original sha: f753e1a * Authored by Thomas Neirynck <thomas@elastic.co> on 2016-11-21T16:48:24Z **Commit 9:** make capitalization consistent * Original sha: 63101d2 * Authored by Thomas Neirynck <thomas@elastic.co> on 2016-11-21T19:47:44Z **Commit 10:** doc checkin * Original sha: fefa40a * Authored by Thomas Neirynck <thomas@elastic.co> on 2016-11-21T21:21:17Z **Commit 11:** minor doc edits * Original sha: 84a8fc3 * Authored by Thomas Neirynck <thomas@elastic.co> on 2016-11-21T21:34:32Z **Commit 12:** doc build issues * Original sha: cd2374a * Authored by Thomas Neirynck <thomas@elastic.co> on 2016-11-21T21:46:59Z

Backports PR elastic#8104 **Commit 1:** tagcloud squashed * Original sha: 1282011 * Authored by Thomas Neirynck <thomas@elastic.co> on 2016-11-18T21:08:29Z **Commit 2:** ensure tags are not turned upside down * Original sha: 68e09f4 * Authored by Thomas Neirynck <thomas@elastic.co> on 2016-11-21T03:43:41Z **Commit 3:** remove unnecessary background * Original sha: dba79b8 * Authored by Thomas Neirynck <thomas@elastic.co> on 2016-11-21T03:55:54Z **Commit 4:** add option to hide the label * Original sha: 7f32544 * Authored by Thomas Neirynck <thomas@elastic.co> on 2016-11-21T04:08:45Z **Commit 5:** use double-ende slider for font-size selection * Original sha: 00c9ea8 * Authored by Thomas Neirynck <thomas@elastic.co> on 2016-11-21T15:26:14Z **Commit 6:** give slider some more space * Original sha: b282084 * Authored by Thomas Neirynck <thomas@elastic.co> on 2016-11-21T16:38:55Z **Commit 7:** do not allow 0-sized tags * Original sha: 42bbc39 * Authored by Thomas Neirynck <thomas@elastic.co> on 2016-11-21T16:44:26Z **Commit 8:** fix typo * Original sha: f753e1a * Authored by Thomas Neirynck <thomas@elastic.co> on 2016-11-21T16:48:24Z **Commit 9:** make capitalization consistent * Original sha: 63101d2 * Authored by Thomas Neirynck <thomas@elastic.co> on 2016-11-21T19:47:44Z **Commit 10:** doc checkin * Original sha: fefa40a * Authored by Thomas Neirynck <thomas@elastic.co> on 2016-11-21T21:21:17Z **Commit 11:** minor doc edits * Original sha: 84a8fc3 * Authored by Thomas Neirynck <thomas@elastic.co> on 2016-11-21T21:34:32Z **Commit 12:** doc build issues * Original sha: cd2374a * Authored by Thomas Neirynck <thomas@elastic.co> on 2016-11-21T21:46:59Z Former-commit-id: 867ff10

thomasneirynck mentioned this pull request Aug 26, 2016

Tag cloud visualization #6975

Closed

stormpython reviewed Aug 31, 2016
View reviewed changes

thomasneirynck mentioned this pull request Sep 1, 2016

Tagcloud #8149

Closed

47 tasks

thomasneirynck force-pushed the tagcloud branch from 2fcc4b9 to f46f639 Compare September 6, 2016 22:04

thomasneirynck assigned jbudz Sep 9, 2016

thomasneirynck added the review label Sep 12, 2016

cjcenizal self-assigned this Sep 12, 2016

thomasneirynck force-pushed the tagcloud branch 2 times, most recently from d812f6c to 6e3b617 Compare October 14, 2016 06:24

cjcenizal reviewed Oct 17, 2016

View reviewed changes

thomasneirynck force-pushed the tagcloud branch from 6e3b617 to e220ae4 Compare October 22, 2016 01:43

thomasneirynck added the tests_needed label Oct 22, 2016

thomasneirynck commented Oct 24, 2016

View reviewed changes

thomasneirynck force-pushed the tagcloud branch 4 times, most recently from d90712a to d4b5f7f Compare October 25, 2016 15:25

thomasneirynck added the Feature:New Vis Request for a new visualization type label Nov 21, 2016

thomasneirynck added 3 commits November 21, 2016 11:38

give slider some more space

b282084

do not allow 0-sized tags

42bbc39

fix typo

f753e1a

thomasneirynck added the v5.1.0 label Nov 21, 2016

make capitalization consistent

63101d2

jbudz approved these changes Nov 21, 2016

View reviewed changes

doc checkin

fefa40a

minor doc edits

84a8fc3

doc build issues

cd2374a

thomasneirynck merged commit 31a6cba into elastic:master Nov 21, 2016

thomasneirynck removed the review label Nov 21, 2016

elastic-jasper mentioned this pull request Nov 23, 2016

[5.1] Tagcloud #9204

Merged

elastic-jasper mentioned this pull request Nov 23, 2016

[5.x] Tagcloud #9205

Merged

ppisljar added the backported label Dec 2, 2016

epixa added v5.1.1 and removed v5.1.0 labels Dec 8, 2016

kermitt2 mentioned this pull request Dec 22, 2016

Word cloud, font size and positionning anHALytics/anHALytics-frontend#57

Open

Conversation

thomasneirynck commented Aug 26, 2016 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

thomasneirynck commented Aug 26, 2016

Uh oh!

thomasneirynck commented Aug 29, 2016 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

markharwood commented Aug 31, 2016

Uh oh!

stormpython Aug 31, 2016

Choose a reason for hiding this comment

Uh oh!

thomasneirynck commented Aug 31, 2016

Uh oh!

markharwood commented Aug 31, 2016

Uh oh!

stormpython commented Aug 31, 2016

Uh oh!

thomasneirynck commented Sep 12, 2016

Uh oh!

jbudz commented Sep 12, 2016 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

thomasneirynck commented Sep 12, 2016

Uh oh!

cjcenizal commented Sep 15, 2016

Uh oh!

thomasneirynck commented Sep 16, 2016

Uh oh!

cjcenizal left a comment

Choose a reason for hiding this comment

Uh oh!

cjcenizal Oct 17, 2016

Choose a reason for hiding this comment

Uh oh!

thomasneirynck Oct 17, 2016 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

cjcenizal Oct 17, 2016

Choose a reason for hiding this comment

Uh oh!

jbudz commented Oct 18, 2016

Uh oh!

thomasneirynck commented Oct 22, 2016 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

thomasneirynck Oct 24, 2016

Choose a reason for hiding this comment

Uh oh!

thomasneirynck commented Nov 21, 2016

Uh oh!

jbudz commented Nov 21, 2016

Uh oh!

thomasneirynck commented Nov 21, 2016

Uh oh!

thomasneirynck commented Nov 21, 2016

Uh oh!

ppisljar commented Nov 21, 2016

Uh oh!

ppisljar commented Nov 21, 2016

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

thomasneirynck commented Aug 26, 2016 •

edited

Loading

thomasneirynck commented Aug 29, 2016 •

edited

Loading

jbudz commented Sep 12, 2016 •

edited

Loading

thomasneirynck Oct 17, 2016 •

edited

Loading

thomasneirynck commented Oct 22, 2016 •

edited

Loading