[Discover] Deangularize context.app#80851
Merged
majagrubic merged 7 commits intoelastic:masterfrom Oct 21, 2020
Merged
Conversation
Contributor
Author
|
@elasticmachine merge upstream |
Contributor
Author
|
@elasticmachine merge upstream |
kertal
reviewed
Oct 20, 2020
Member
kertal
left a comment
There was a problem hiding this comment.
Thanks for moving this old rock! Tested locally in Chrome, Safari, Firefox, works 👍, left some code comments and suggestions, one thing is mandatory i18n provider is missing leading to the following message in the browsers console:
src/plugins/discover/public/application/components/context_app/constants.ts
Show resolved
Hide resolved
src/plugins/discover/public/application/components/context_app/context_app_legacy.tsx
Outdated
Show resolved
Hide resolved
| _version: 1, | ||
| _source: { | ||
| category: ["Men's Clothing"], | ||
| currency: 'EUR', |
Member
There was a problem hiding this comment.
Nit: Walker Text Ranger's first name ist Cordell and he would never pay in EUR !
kertal
reviewed
Oct 20, 2020
src/plugins/discover/public/application/components/context_app/context_app_legacy.tsx
Outdated
Show resolved
Hide resolved
kertal
reviewed
Oct 20, 2020
src/plugins/discover/public/application/components/context_app/context_app_legacy.tsx
Show resolved
Hide resolved
added 2 commits
October 20, 2020 17:15
Contributor
💚 Build SucceededMetrics [docs]@kbn/optimizer bundle module count
async chunks size
History
To update your PR or re-run it, just comment with: |
kertal
approved these changes
Oct 21, 2020
Member
kertal
left a comment
There was a problem hiding this comment.
Code LGTM, thanks for also removing kui classes, checked it out, tested in Chrome, Firefox, Safari, works 👍
jloleysens
added a commit
to jloleysens/kibana
that referenced
this pull request
Oct 21, 2020
…arm-phase-to-formlib * 'master' of github.com:elastic/kibana: (55 commits) [UX] Fix map color variance and apply proper filter for extended stats (elastic#81106) [User Experience] Use EuiSelect for percentiles instead of SuperSelect (elastic#81082) [DOCS] Add link for monitoring ssl settings (elastic#81057) [test] Await loading indicator in monitoring test (elastic#81279) [ILM] Minor copy and link additions to cloud CTA for cold phase (elastic#80512) [Mappings editor] Add scaled_float and date_range comp integration tests (elastic#81287) [Discover] Deangularize context.app (elastic#80851) [O11y Overview] Add code to display/hide UX section when appropriate (elastic#80873) [Discover] Extend DiscoverNoResults component to show different message on error (elastic#79671) Fix tagcloud word overlapping (elastic#81161) [Security Solution] Fixes flaky test rules (elastic#81040) Changed the code to avoid tech debt with hacky solutions after receiving comments on EUI issue reported about this problem. (elastic#81183) [Security Solution][All] Replace old markdown renderer with the new one (elastic#80301) Add namespaced version of the API call (elastic#81278) [ML] Data Frame Analytics: Fix race condition and support for feature influence legacy format. (elastic#81123) [Fleet] Fix POLICY_CHANGE action creation for new policy (elastic#81236) [Security Solution][Endpoint][Admin] Malware user notification checkbox (elastic#78084) [SecuritySolution][Unit Tests] - fix flakey unit test (elastic#81239) skip flaky suite (elastic#81264) [Maps] fix top-level Map page is called 'Kibana' (elastic#81238) ... # Conflicts: # x-pack/plugins/index_lifecycle_management/public/application/sections/edit_policy/components/phases/hot_phase/hot_phase.tsx # x-pack/plugins/index_lifecycle_management/public/application/sections/edit_policy/components/phases/shared/forcemerge_field.tsx # x-pack/plugins/index_lifecycle_management/public/application/sections/edit_policy/components/phases/warm_phase.tsx
majagrubic
pushed a commit
that referenced
this pull request
Oct 22, 2020
* [Discover] Deangularize context.app * Add a unit test * Addressing PR comments; fixin I18n provider; replacing kui with EUI code Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Addresses: #70211
Moves doc-table part of
context_app.htmlto React component and creates a new directive.Checklist
Delete any items that are not applicable to this PR.
- [ ] Documentation was added for features that require explanation or tutorials- [ ] This renders correctly on smaller devices using a responsive layout. (You can test this in your browser)- [ ] This was checked for cross-browser compatibilityFor maintainers