cleaning up expression service types#80643
Merged
ppisljar merged 2 commits intoelastic:masterfrom Oct 26, 2020
Merged
Conversation
Contributor
|
Pinging @elastic/kibana-app-arch (Team:AppArch) |
Contributor
|
I think Wylie just merged his PR which exposes |
0754cd7 to
c81a42e
Compare
c81a42e to
90b1f5b
Compare
13 tasks
90b1f5b to
613f873
Compare
6 tasks
613f873 to
de93ecf
Compare
de93ecf to
05aca66
Compare
lukeelmers
reviewed
Oct 22, 2020
Contributor
lukeelmers
left a comment
There was a problem hiding this comment.
Couple minor TS nits, but overall this cleanup makes things much clearer! 👍
| : createDefaultInspectorAdapters()) as InspectorAdapters, | ||
| inspectorAdapters: | ||
| execution.params.inspectorAdapters || | ||
| ((createDefaultInspectorAdapters() as any) as InspectorAdapters), |
Contributor
There was a problem hiding this comment.
looks like DefaultInspectorAdapters extends Adapters, why is the as any) as InspectorAdapters necessary here?
Comment on lines
+53
to
+55
| query: [...toArray((getSearchContext() as any).query), ...toArray((input || {}).query)], | ||
| filters: [...((getSearchContext() as any).filters || []), ...((input || {}).filters || [])], | ||
| timeRange: (getSearchContext() as any).timeRange || (input ? input.timeRange : undefined), |
Contributor
There was a problem hiding this comment.
Feels like we shouldn't need to cast to any here -- presumably getSearchContext() is getting its type from ExecutionContextSearch, in which case query, filters, timeRange are all undefined so you should still be able to use them right?
(Or worst-case do getSearchContext().query!)
Contributor
💚 Build SucceededMetrics [docs]page load bundle size
History
To update your PR or re-run it, just comment with: |
stratoula
approved these changes
Oct 26, 2020
Contributor
stratoula
left a comment
There was a problem hiding this comment.
Code review only of the kibana app team. LGTM!
jloleysens
added a commit
to jloleysens/kibana
that referenced
this pull request
Oct 26, 2020
…arm-phase-to-formlib * 'master' of github.com:elastic/kibana: [Trigger Actions UI] Properly unmount app (elastic#81436) skip flaky suite (elastic#81576) skip flaky suite (elastic#78373) [Security Solution] Fix styling of EditDataProvider content (elastic#81456) [Search] Error Alignment 2 (elastic#80965) [APM] Unskip test (elastic#81574) [ML] Fix partition value selection on the Single Metric Viewer (elastic#81585) cleaning up expression service types (elastic#80643) Fix suggestions dropdown for query input (elastic#80990) [Usage collection] Make `schema` mandatory (elastic#79999) [ILM] Update show/hide data tier logic on cloud (elastic#81455) added brace import to advanced settings (elastic#81458) chore(NA): add spec-to-console and plugin-helpers as devOnly dependencies
ppisljar
added a commit
that referenced
this pull request
Oct 26, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Cleans up some types on expressions and:
getInitialInput()fromcontext(which was not used by anyone)context.searchbehind context.getSearchContext() methodgetSearchSessionId()to context as well assearchSessionIdparameter to executor/loaderChecklist
Delete any items that are not applicable to this PR.
For maintainers