[Ingest Manager] Index pattern installation use requested package version#80079
Merged
jonathan-buttner merged 4 commits intoelastic:masterfrom Oct 12, 2020
Merged
Conversation
Contributor
|
Pinging @elastic/ingest-management (Feature:EPM) |
Contributor
|
Pinging @elastic/ingest-management (Team:Ingest Management) |
nchaulet
reviewed
Oct 8, 2020
| // TODO: handle update case when versions are different | ||
| if (!foundPkg) { | ||
| installedPackages.push({ pkgName, pkgVersion }); | ||
| const packageToInstall = packageVersionsToFetch.findIndex((pkg) => pkg.pkgName === pkgName); |
Member
There was a problem hiding this comment.
nitpick: any reason of not using find here? and mutate packageToInstall. pkgVersion after?
Contributor
Author
There was a problem hiding this comment.
Thanks, I'll update 👍
skh
approved these changes
Oct 12, 2020
Contributor
skh
left a comment
There was a problem hiding this comment.
Thanks for the testing instructions! This works as described. 👍
…tern-latest-package
Contributor
💚 Build SucceededMetrics [docs]
History
To update your PR or re-run it, just comment with: |
jonathan-buttner
added a commit
to jonathan-buttner/kibana
that referenced
this pull request
Oct 12, 2020
…sion (elastic#80079) * Install the requested package version * Add test for correct package fields * Addressing feedback
jonathan-buttner
added a commit
to jonathan-buttner/kibana
that referenced
this pull request
Oct 12, 2020
…sion (elastic#80079) * Install the requested package version * Add test for correct package fields * Addressing feedback
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR addresses this issue: #80022
The index pattern installation process previously requested the latest package version to retrieve the fields for installing the
logs-*andmetrics-*kibana index patterns. It ignored the requested package version passed into the function. This PR fixes it to use the passed in version if it was specified.Testing
0.13.1caselessfields were added in0.16.0)