Speed up filter creation in functional tests#80037
Merged
lizozom merged 3 commits intoelastic:masterfrom Oct 14, 2020
Merged
Conversation
Contributor
|
Pinging @elastic/kibana-app-arch (Team:AppArch) |
Contributor
Author
|
@elasticmachine merge upstream |
Contributor
|
Would you mind testing this out a few times with the flaky suite runner to understand if this causes any flakiness in big consumers of the service? |
Contributor
Author
|
@splager running https://kibana-ci.elastic.co/job/kibana+flaky-test-suite-runner/899/ |
Contributor
|
@elasticmachine merge upstream |
Contributor
💚 Build SucceededMetrics [docs]
History
To update your PR or re-run it, just comment with: |
spalger
approved these changes
Oct 13, 2020
Contributor
spalger
left a comment
There was a problem hiding this comment.
200 successful executions with https://kibana-ci.elastic.co/job/kibana+flaky-test-suite-runner/903/ and https://kibana-ci.elastic.co/job/kibana+flaky-test-suite-runner/904/, LGTM
lizozom
added a commit
to lizozom/kibana
that referenced
this pull request
Oct 14, 2020
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
lizozom
added a commit
that referenced
this pull request
Oct 14, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Summarize your PR. If it involves visual changes include a screenshot or gif.
Checklist
Delete any items that are not applicable to this PR.
For maintainers