Merged
Conversation
Contributor
|
Pinging @elastic/kibana-app (Team:KibanaApp) |
Contributor
|
Pinging @elastic/kibana-app-arch (Team:AppArch) |
Contributor
Author
|
@elasticmachine merge upstream |
Contributor
Author
|
@elasticmachine merge upstream |
lukeelmers
approved these changes
Oct 13, 2020
Contributor
lukeelmers
left a comment
There was a problem hiding this comment.
I think the implementation here makes sense, but would be great if we could add a few unit tests, perhaps on terms agg and/or median agg type.
Tested Chrome (macOS), looks good!
Contributor
💚 Build SucceededMetrics [docs]page load bundle size
History
To update your PR or re-run it, just comment with: |
flash1293
added a commit
to flash1293/kibana
that referenced
this pull request
Oct 14, 2020
flash1293
added a commit
that referenced
this pull request
Oct 14, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #79836
This PR makes it possible to sort by median by prefixing the bucket path in the terms agg with
.50. This is necessary because median uses percentiles under the hood which is a multi metric, so it's necessary to point to the specific value within the multi metric.To handle this, I introduced a new property
getValueBucketPathon the agg config which is passed in from the agg type. The default implementation just takes the id, for the median type it's implemented by adding the.50suffix.