[ML] Fixes anomaly detection jobs list load if call to load job messages fails#79792
Merged
qn895 merged 4 commits intoelastic:masterfrom Oct 8, 2020
Merged
Conversation
darnautov
reviewed
Oct 7, 2020
...ck/plugins/ml/public/application/jobs/jobs_list/components/job_details/job_messages_pane.tsx
Outdated
Show resolved
Hide resolved
Contributor
|
Pinging @elastic/ml-ui (:ml) |
Contributor
peteharverson
left a comment
There was a problem hiding this comment.
Tested and left a suggestion for a change to the toast title.
Also if possible can we show the same sort of error toast for the data frame analytics jobs list? The list is displaying ok if that index mapping is incorrect, but the error is only shown in the browser console. Would be nice to show that same error toast for the DFA page too. Note that job details section is also shown in the DFA results page.
...ck/plugins/ml/public/application/jobs/jobs_list/components/job_details/job_messages_pane.tsx
Outdated
Show resolved
Hide resolved
peteharverson
approved these changes
Oct 7, 2020
Contributor
peteharverson
left a comment
There was a problem hiding this comment.
Tested latest edit and LGTM
Member
Author
|
@elasticmachine merge upstream |
Contributor
💚 Build SucceededMetrics [docs]async chunks size
History
To update your PR or re-run it, just comment with: |
qn895
added a commit
to qn895/kibana
that referenced
this pull request
Oct 8, 2020
…ges fails (elastic#79792) Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
qn895
added a commit
to qn895/kibana
that referenced
this pull request
Oct 8, 2020
…ges fails (elastic#79792) Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes #77350. The wrong index mapping causes
getAuditMessagesSummaryto fail, which causejobsSummaryto throw an error. This PR makes it so that:Job Messagetab will bubble up a more explicit error message in the UIBefore
After
Checklist
Delete any items that are not applicable to this PR.