[Telemetry Tools] Merge array of constraints#79654
Merged
afharo merged 1 commit intoelastic:masterfrom Oct 6, 2020
Merged
Conversation
Contributor
|
Pinging @elastic/kibana-telemetry (Team:KibanaTelemetry) |
Bamieh
approved these changes
Oct 6, 2020
Contributor
💛 Build succeeded, but was flaky
Test FailuresX-Pack EPM API Integration Tests.x-pack/test/ingest_manager_api_integration/apis/fleet/agents/upgrade·ts.Ingest Manager Endpoints Fleet Endpoints fleet upgrade agent should not upgrade an unenrolled agent during bulk_upgradeStandard OutStack TraceMetrics [docs]
To update your PR or re-run it, just comment with: |
afharo
added a commit
that referenced
this pull request
Oct 6, 2020
Contributor
|
Pinging @elastic/kibana-core (Team:Core) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When defining
Record<AllProps, SOMETHING>, andtype AllProps = OneList | AnotherList, thegetConstraintsmethod was returning an array of arrays instead of 1 flattened array of strings.This PR fixes that behaviour.
Related to #79587
Checklist
Delete any items that are not applicable to this PR.
For maintainers