[App Search] Temporarily remove sidebar layout for 7.10 release#79506
Merged
cee-chen merged 1 commit intoelastic:masterfrom Oct 5, 2020
Merged
[App Search] Temporarily remove sidebar layout for 7.10 release#79506cee-chen merged 1 commit intoelastic:masterfrom
cee-chen merged 1 commit intoelastic:masterfrom
Conversation
- Since our other top level pages (settings, credentials, role mappings) aren't yet ready, we'll stick to the same UI for 7.9, only showing the Engines Overview to users
Contributor
Author
|
@elastic/enterprise-search-frontend Pinging for an approval since this is a time-sensitive PR that needs to be merged in by EOD today. The follow-up PR reverting the change will not be time-sensitive. Thank you! 🙇♀️ |
Contributor
Author
|
|
1 task
Contributor
|
@elasticmachine merge upstream |
Contributor
|
ignoring request to update branch, pull request is closed |
JasonStoltz
pushed a commit
to JasonStoltz/kibana
that referenced
this pull request
Oct 6, 2020
…ease (elastic#79506)" This reverts commit d5b8a95.
Merged
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Since our other top level pages (settings, credentials, role mappings) aren't yet ready, we're reverting to the 7.9 UI for 7.10 (i.e., only showing the Engines Overview to users).
Screencaps
QA
Checklist
Please note: this commit will immediately be reverted for 7.x/7.11 once the 7.10 branch is cut (tomorrow/FF). At that point, this PR should only exist in the 7.10 branch.