Skip to content

[cli] migrate remaining cli scripts to /dist /dev style#79409

Merged
spalger merged 7 commits intoelastic:masterfrom
spalger:fix/cli-polyfill-prod
Oct 5, 2020
Merged

[cli] migrate remaining cli scripts to /dist /dev style#79409
spalger merged 7 commits intoelastic:masterfrom
spalger:fix/cli-polyfill-prod

Conversation

@spalger
Copy link
Copy Markdown
Contributor

@spalger spalger commented Oct 5, 2020 •
edited
Loading

Fixes #79470
Fixes #79472

With #79379 we migrated to a different setup strategy for the dist and dev Kibana CLI, with the dev version loading automatic transpilation and the dist version only loading polyfills. This transition didn't make its way to the rest of the CLIs that are included in the distributable.

@spalger spalger added Team:Operations Kibana-Operations Team v8.0.0 release_note:skip Skip the PR/issue when compiling release notes v7.10.0 labels Oct 5, 2020
@spalger spalger requested a review from a team October 5, 2020 02:02
@spalger spalger requested a review from a team as a code owner October 5, 2020 02:02
@spalger spalger requested a review from a team October 5, 2020 02:02
@spalger spalger requested review from a team as code owners October 5, 2020 02:02
@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Oct 5, 2020

Pinging @elastic/kibana-operations (Team:Operations)

@botelastic botelastic bot added Team:APM - DEPRECATED Use Team:obs-ux-infra_services. Team:Fleet Team label for Observability Data Collection Fleet team labels Oct 5, 2020
@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Oct 5, 2020

Pinging @elastic/apm-ui (Team:apm)

@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Oct 5, 2020

Pinging @elastic/ingest-management (Team:Ingest Management)

@spalger spalger force-pushed the fix/cli-polyfill-prod branch from 93be953 to f4a1a8a Compare October 5, 2020 02:15
@spalger spalger removed request for a team October 5, 2020 04:46
@spalger spalger force-pushed the fix/cli-polyfill-prod branch from b5b6e51 to d7fe311 Compare October 5, 2020 04:49
@spalger spalger removed Team:Fleet Team label for Observability Data Collection Fleet team Team:APM - DEPRECATED Use Team:obs-ux-infra_services. labels Oct 5, 2020
tylersmalley
tylersmalley requested changes Oct 5, 2020
View reviewed changes
Copy link
Copy Markdown
Member

@tylersmalley tylersmalley left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since there is no more index files, we need to update the bin scripts. Otherwise:

$./bin/kibana-keystore
internal/modules/cjs/loader.js:638
    throw err;
    ^

Error: Cannot find module '/home/tyler/test/kibana-8.0.0-SNAPSHOT-linux-x86_64/src/cli_keystore'
    at Function.Module._resolveFilename (internal/modules/cjs/loader.js:636:15)
    at Function.Module._load (internal/modules/cjs/loader.js:562:25)
    at Function.Module.runMain (internal/modules/cjs/loader.js:831:12)
    at startup (internal/bootstrap/node.js:283:19)
    at bootstrapNodeJSCore (internal/bootstrap/node.js:623:3)

@spalger
Merge branch 'master' of github.com:elastic/kibana into fix/cli-polyf…
8b74490 
…ill-prod

# Conflicts:
#	src/dev/build/tasks/copy_source_task.ts
@spalger
Copy link
Copy Markdown
Contributor Author

spalger commented Oct 5, 2020

@elasticmachine merge upstream

@tylersmalley tylersmalley mentioned this pull request Oct 5, 2020
Merged
@kibanamachine
Copy link
Copy Markdown
Contributor

kibanamachine commented Oct 5, 2020

💚 Build Succeeded

Metrics [docs]

distributable file count

id before after diff
default 48094 48097 +3
oss 28993 28996 +3

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@spalger spalger merged commit 3d6f150 into elastic:master Oct 5, 2020
@spalger spalger deleted the fix/cli-polyfill-prod branch October 5, 2020 22:07
@spalger spalger mentioned this pull request Oct 5, 2020
Merged
spalger added a commit that referenced this pull request Oct 5, 2020
@spalger @kibanamachine
[cli] migrate remaining cli scripts to /dist /dev style (#79409) (#79586
c6fa5cd 
)

Co-authored-by: spalger <spalger@users.noreply.github.com>
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
# Conflicts:
#	src/dev/build/tasks/copy_source_task.ts
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tylersmalley tylersmalley tylersmalley approved these changes

Assignees

No one assigned

Labels

release_note:skip Skip the PR/issue when compiling release notes Team:Operations Kibana-Operations Team v7.10.0 v8.0.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

kibana-keystore create Cannot find module './babel_register' kibana-keystore create Cannot find module '@kbn/optimizer'

4 participants

@spalger @elasticmachine @kibanamachine @tylersmalley