[core/server/plugins] don't run discovery in dev server parent process#79235
Merged
spalger merged 3 commits intoelastic:masterfrom Oct 2, 2020
Merged
Conversation
Contributor
|
Pinging @elastic/kibana-platform (Team:Platform) |
Contributor
Author
|
@elasticmachine merge upstream |
pgayvallet
approved these changes
Oct 2, 2020
Contributor
pgayvallet
left a comment
There was a problem hiding this comment.
Can we just add a unit test, for when we'll decide of a more heavy refactoring of the behavior when isDevClusterMaster is true?
…sterMaster is true
joshdover
approved these changes
Oct 2, 2020
Contributor
💚 Build SucceededMetrics [docs]
History
To update your PR or re-run it, just comment with: |
spalger
added a commit
to spalger/kibana
that referenced
this pull request
Oct 2, 2020
elastic#79235) Co-authored-by: spalger <spalger@users.noreply.github.com> Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
spalger
added a commit
to spalger/kibana
that referenced
this pull request
Oct 2, 2020
…er parent process (elastic#79235)"" This reverts commit 66878b4.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extracted from #78710
This prevents the dev server from loading plugins in the core when it's started just for the purpose of launching the
ClusterManagerandBasePathProxy.