[ML] Fix registering home screen panel#79080
Merged
peteharverson merged 7 commits intoelastic:masterfrom Oct 7, 2020
Merged
Conversation
Member
|
Checking stability in a flaky test runner job ... no failure in 50 runs ✔️ |
Member
|
@elasticmachine merge upstream |
Member
|
Checked stability in another flaky test runner job: no failure in 50 runs ✔️ |
fdfebcf to
3c37505
Compare
Contributor
Author
|
@elasticmachine merge upstream |
Contributor
|
Pinging @elastic/ml-ui (:ml) |
Contributor
Author
|
@elasticmachine merge upstream |
Contributor
|
@elasticmachine merge upstream |
Member
|
@elasticmachine merge upstream |
Contributor
💚 Build SucceededMetrics [docs]async chunks size
page load bundle size
History
To update your PR or re-run it, just comment with: |
peteharverson
pushed a commit
to peteharverson/kibana
that referenced
this pull request
Oct 7, 2020
* [ML] Import tweak. * [ML] Attempt at fixing flaky registering. * [ML] Re-enable tests. Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
peteharverson
added a commit
that referenced
this pull request
Oct 7, 2020
* [ML] Import tweak. * [ML] Attempt at fixing flaky registering. * [ML] Re-enable tests. Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: Walter Rafelsberger <walter@elastic.co> Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
patrykkopycinski
pushed a commit
to patrykkopycinski/kibana
that referenced
this pull request
May 6, 2026
* [ML] Import tweak. * [ML] Attempt at fixing flaky registering. * [ML] Re-enable tests. Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #78965.
Fixes a race condition on plugin load which could lead to registered features not showing up in other parts of Kibana.
Originally we had the bundle size down to 40Kb. With some other later PRs related to shared code and this fix we're at 64Kb. In relation to the 40Kb that's quite the increase, but the important bit here is we fixed the race condition in time for 7.10 FF and are still way down from the previous ~800Kb we had.
Checklist
Delete any items that are not applicable to this PR.