[Usage Collection] [schema] apm#79000
Conversation
| APM_TELEMETRY_SAVED_OBJECT_ID, | ||
| APM_TELEMETRY_SAVED_OBJECT_TYPE, | ||
| } from '../../../common/apm_saved_object_constants'; | ||
| import { getApmTelemetryMapping } from '../../../common/apm_telemetry'; |
There was a problem hiding this comment.
Maybe we can delete that method, and stop maintaining the script upload-telemetry-data. It can be deleted on a follow up PR, though. What do you think @elastic/apm-ui?
There was a problem hiding this comment.
We use upload-telemetry-data to test if changes we make in development actually work. Couldn't we keep it have it use apmSchema? Not sure why we would want to delete it unless we have a better way to verify that are tasks work in development.
There was a problem hiding this comment.
@smith sure! If the APM team uses upload-telemetry-data for additional purposes other than provide an up-to-date mappings to the telemetry cluster. I have nothing against keeping it. That's also why I didn't remove it in this PR. It's your call 🙂
schema provides a double validation: TS and Telemetry-Tools about the data matching the structure. I understand if you also want to use the upload-telemetry-data for functional tests.
There was a problem hiding this comment.
@afharo upload-telemetry-data is not used to provide mappings to the telemetry cluster; it's only used in development.
There was a problem hiding this comment.
Got it! I agree then! There's no need to remove it. Sorry for the misunderstanding 😇
|
Pinging @elastic/kibana-telemetry (Team:KibanaTelemetry) |
|
Pinging @elastic/apm-ui (Team:apm) |
smith
left a comment
There was a problem hiding this comment.
This looks great! Could you please remove the getApmTelemetryMapping() function and its tests and update mergeApmTelemetryMapping to use the APM scheme here? https://github.com/elastic/kibana/blob/master/x-pack/plugins/apm/common/apm_telemetry.ts#L271
…a into usage_collection/schema/apm
|
@smith as requested, I've updated |
💚 Build SucceededMetrics [docs]distributable file count
History
To update your PR or re-run it, just comment with: |
In elastic#79000 the way we create the telemetry schema was updated and APM is no longer excluded from the telemetry scripts. Update the docs to be more correct about this.
In #79000 the way we create the telemetry schema was updated and APM is no longer excluded from the telemetry scripts. Update the docs to be more correct about this.
In elastic#79000 the way we create the telemetry schema was updated and APM is no longer excluded from the telemetry scripts. Update the docs to be more correct about this.
|
Pinging @elastic/kibana-core (Team:Core) |
Summary
schemadefinition to the collectorapm.@kbn/telemetry-tool: Add support toRecord<'prop1' | 'prop2', SOMETHING>(previously only supportingRecord<string, SOMETHING>).@kbn/telemetry-tool: Add support toPick<SOMETHING, 'prop1' | 'prop2'>.Related to #70180.
Closes #72736.
Checklist
For maintainers