[7.10][Telemetry] Display collected security event sample#78963
Merged
pjhampton merged 9 commits intoelastic:masterfrom Oct 2, 2020
pjhampton:@pjhampton/68942
Merged
[7.10][Telemetry] Display collected security event sample#78963pjhampton merged 9 commits intoelastic:masterfrom pjhampton:@pjhampton/68942
pjhampton merged 9 commits intoelastic:masterfrom
pjhampton:@pjhampton/68942
Conversation
afharo
reviewed
Sep 30, 2020
Comment on lines
+208
to
+211
| clusterData: <EuiLink onClick={this.toggleExample}>cluster data</EuiLink>, | ||
| endpointSecurityData: ( | ||
| <EuiLink onClick={this.toggleSecurityExample}>endpoint security data</EuiLink> | ||
| ), |
Member
There was a problem hiding this comment.
Should we add new translation IDs for cluster data and endpoint security data as well?
Contributor
Author
|
@elasticmachine merge upstream |
TinaHeiligers
approved these changes
Oct 1, 2020
Contributor
TinaHeiligers
left a comment
There was a problem hiding this comment.
I was reviewing under the assumption that endpoint was still a product and shouldn't be translated 🤦♀️ . Good catch!
LGTM
stevewritescode
approved these changes
Oct 1, 2020
pjhampton
added a commit
that referenced
this pull request
Oct 2, 2020
…79293) * Add security example to usage data opt in panel. * Update translations. * Fix docs. * Fix broken type. Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com> Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
6 tasks
9 tasks
Contributor
💔 Build Failed
Failed CI Steps
Test FailuresJest Integration Tests.packages/kbn-plugin-helpers/src/integration_tests.builds a generated plugin into a viable archiveStandard OutStack TraceMetrics [docs]
History
To update your PR or re-run it, just comment with: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #68942
Related to #77200
Related to #78262 (Closed PR)
Summary
This PR adds a fly-out with an example of a security event collected from Elastic Endpoint when enabled.
Discussion items from #78262
Checklist
Delete any items that are not applicable to this PR.
For maintainers