[UX] Improve page-load axis#78392
Merged
shahzad31 merged 17 commits intoelastic:masterfrom Oct 1, 2020
Merged
Conversation
Contributor
|
Pinging @elastic/apm-ui (Team:apm) |
Contributor
|
Pinging @elastic/uptime (Team:uptime) |
Contributor
Author
|
@elasticmachine merge upstream |
Contributor
Author
|
@elasticmachine merge upstream |
Contributor
justinkambic
left a comment
There was a problem hiding this comment.
Had a few questions/corrections, but looks good!
| numeral(pageViewsTotal).format('0,0') | ||
| ) : ( | ||
| <EuiToolTip content={numeral(pageViewsTotal).format('0,0')}> | ||
| <>{numeral(pageViewsTotal).format('0 a')}</> |
Contributor
Author
There was a problem hiding this comment.
EuiTitle goes crazy if simple text is provided as child, it needs element.
x-pack/plugins/apm/server/lib/rum_client/get_page_load_distribution.ts
Outdated
Show resolved
Hide resolved
| const NUMBER_OF_PLD_STEPS = 100; | ||
|
|
||
| export function microToSec(val: number) { | ||
| return Math.round((val / MICRO_TO_SEC + Number.EPSILON) * 100) / 100; |
Contributor
There was a problem hiding this comment.
I'm just noticing this, but why the usage of Number.EPSILON?
Given that we are using Math.round on the result, is adding Number.EPSILON to val/MICRO_TO_SEC going to have any significant outcome on the output of Math.round? Sorry if I'm missing something, it just seemed strange to me.
Contributor
Author
There was a problem hiding this comment.
i think i wanted to two decimal places here without rounding out the values.
Contributor
Author
|
@elasticmachine merge upstream |
justinkambic
approved these changes
Sep 30, 2020
Contributor
💚 Build SucceededMetrics [docs]async chunks size
History
To update your PR or re-run it, just comment with: |
shahzad31
added a commit
to shahzad31/kibana
that referenced
this pull request
Oct 1, 2020
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
gmmorris
added a commit
to gmmorris/kibana
that referenced
this pull request
Oct 1, 2020
* master: (36 commits) [I18n] fix eui tokens (elastic#78951) Changed the color of the confirm button in trusted app deletion dialog. (elastic#78768) Make the actual Vislib import async (elastic#78949) Fix ML conditionals links Cypress tests (elastic#78568) [Drilldowns][Docs] Communicate the visualization types that support drilldowns (elastic#78761) [UX] Improve page-load axis (elastic#78392) [SECURITY SOLUTIONS] Map embeddable working with index patterns selection (elastic#78610) Data plugin README (elastic#78750) [TSVB] Request validation error: [panels.0.series.0.metrics.0.percentiles.1.value] (elastic#79009) fixing api test (elastic#78964) [Task names in TaskManager] Rename "telemetry" to "usage" (elastic#78129) [Loggers] Rename "telemetry" to "usage" (elastic#78130) [Usage Collection] [schema] `ui_metric` (elastic#78827) [Actions][Jira] Set parent issue for Sub-task issue type (elastic#78772) [Discover] Unskip doc link functional test (elastic#78600) [ML] Functional tests - stabilize calendar edit tests (elastic#78950) [UX] Improve page responsive (elastic#78759) [QA][Code Coverage] Team Assignment Docs Update (elastic#78890) [ML] Migrate machine learning URLs to BrowserRouter format for APM, Security, and Infra (elastic#78209) [ts] enable "resolveJsonModule" and disable existing failures (elastic#78855) ...
shahzad31
added a commit
that referenced
this pull request
Oct 1, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary