bump @testing-library by Dosant · Pull Request #78270 · elastic/kibana

Dosant · 2020-09-23T10:53:50Z

Summary

Bumps @testing-library/* libs

Notable changes:

wait is deprecated. waitFor and find should be used. docs
There is new user-event add-on, which is better version of lower level fireEvent https://github.com/testing-library/user-event
Apparently a11y checks have been improved: bump @testing-library #78270 (comment) 🥳

Note:

This race-condition with afterEach still exists: [Unit Testing][Flaky] Jest suite and react-testing-library registration race condition #59469 and should be addressed separately. For now, I'd recommend import from @testing-library/react/pure instead of @testing-library/react and cleanUp() manually

Dosant

Notes below

Dosant · 2020-09-23T12:31:54Z

src/dev/jest/setup/react_testing_library.js


 // instead of default 'data-testid', use kibana's 'data-test-subj'
-configure({ testIdAttribute: 'data-test-subj' });
+configure({ testIdAttribute: 'data-test-subj', asyncUtilTimeout: 4500 });


before 4500 was a default. now it is 1000. Forcing 4500 back as some tests were failing

Dosant · 2020-09-23T12:32:49Z

x-pack/plugins/apm/public/hooks/useFetcher.test.tsx


 describe('useFetcher', () => {
  describe('when resolving after 500ms', () => {
-    let hook: ReturnType<typeof renderHook>;


Something around types of renderHook has changed that it is now more strict and doesn't allow use hook with this inferred type

Dosant · 2020-09-23T12:33:35Z

...plugins/infra/public/pages/metrics/metrics_explorer/hooks/use_metrics_explorer_data.test.tsx

    return <KibanaContextProvider services={services}>{children}</KibanaContextProvider>;
  };
  return renderHook(
-    (props) =>


Otherwise it says that props.options and others are missing. I didn't find a way how to nicely infer it from useMetricsExplorerData, so just copied types

Dosant · 2020-09-23T12:35:07Z

x-pack/plugins/security_solution/public/cases/components/user_action_tree/index.test.tsx

-        .find(`[data-test-subj="description-action"] [data-test-subj="property-actions-quote"]`)
-        .first()
-        .simulate('click');
+        wrapper


Internal implementation of waitFor significantly changed between versions. Not sure why exactly, but I had to move this check inside waitFor to make test pass

Dosant · 2020-09-23T12:36:34Z

...nsform/public/app/sections/create_transform/components/step_define/step_define_form.test.tsx


    // Act
    // Assert
-    expect(getByLabelText('Index pattern')).toBeInTheDocument();


Here it threw error that Index pattern label is labelling span, which is incorrect.
I fixed the test, but this component should be reviewed from labels/a11y perspective

This was the error here:

TestingLibraryElementError: Found a label with the text of: Index pattern, however the element associated with this label () is non-labellable [https://html.spec.whatwg.org/multipage/forms.html#category-label]. If you really need to label a , you can use aria-label or aria-labelledby instead.

Thanks for flagging this up @Dosant . Yes we have a  inside an <EuiFormRow> on this page. Do you know what would be better from the a11y perspective? Should we replace the  with EuiText? This form row is displaying a non-editable piece of text (here 'gallery-*' is the span content):

Dosant · 2020-09-23T13:44:41Z

x-pack/plugins/ui_actions_enhanced/public/components/action_wizard/action_wizard.test.tsx

  // check that all factories are displayed to pick
  expect(screen.getAllByTestId(new RegExp(TEST_SUBJ_ACTION_FACTORY_ITEM))).toHaveLength(2);

-  expect(screen.getByText(/Go to URL/i)).toBeDisabled();


There is button with a lot of nested content inside. It stopped returning a button, but returns a nested p instead.

Dosant · 2020-09-23T13:45:10Z

...ns/components/connected_flyout_manage_drilldowns/connected_flyout_manage_drilldowns.test.tsx

    target: { value: URL },
  });

-  [createHeading, createButton] = screen.getAllByText(/Create Drilldown/i);


createButton is a button with nested content inside. It stopped returning a button, but returns a nested p instead.

mistic

Changes on files under operations team code owners LGTM

elasticmachine · 2020-09-23T13:57:54Z

Pinging @elastic/apm-ui (Team:apm)

weltenwort

infra plugin changes LGTM

sorenlouv

Thanks for taking the time @Dosant !

patrykkopycinski

😍 Thank you @Dosant (SIEM/Endpoint)

peteharverson

Transforms text edit LGTM.

Do you know what we should be using instead of the ?

peteharverson · 2020-09-24T08:42:51Z

...nsform/public/app/sections/create_transform/components/step_define/step_define_form.test.tsx


    // Act
    // Assert
-    expect(getByLabelText('Index pattern')).toBeInTheDocument();


Thanks for flagging this up @Dosant . Yes we have a  inside an <EuiFormRow> on this page. Do you know what would be better from the a11y perspective? Should we replace the  with EuiText? This form row is displaying a non-editable piece of text (here 'gallery-*' is the span content):

streamich

LGTM

kibanamachine · 2020-09-29T13:50:03Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request
Commit: 1c2389d

Metrics [docs]

async chunks size

id	value	diff	baseline
`enterpriseSearch`	632.2KB	+62.0B	632.1KB

page load bundle size

id	value	diff	baseline
`upgradeAssistant`	64.6KB	+31.0B	64.5KB

History

💚 Build #76849 succeeded 1c2389d
💚 Build #76491 succeeded 5054eba
💔 Build #76473 failed 0f5946c

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

Dosant added 2 commits September 23, 2020 12:52

wip

0f5946c

fix tests

5054eba

Dosant commented Sep 23, 2020

View reviewed changes

Dosant added Feature:Unit Testing release_note:skip Skip the PR/issue when compiling release notes v7.10.0 v8.0.0 labels Sep 23, 2020

Dosant commented Sep 23, 2020

View reviewed changes

Dosant marked this pull request as ready for review September 23, 2020 13:47

Dosant requested a review from a team September 23, 2020 13:47

Dosant requested review from a team as code owners September 23, 2020 13:47

mistic approved these changes Sep 23, 2020

View reviewed changes

botelastic bot added the Team:APM - DEPRECATED Use Team:obs-ux-infra_services. label Sep 23, 2020

weltenwort approved these changes Sep 23, 2020

View reviewed changes

sorenlouv approved these changes Sep 23, 2020

View reviewed changes

patrykkopycinski approved these changes Sep 23, 2020

View reviewed changes

peteharverson approved these changes Sep 24, 2020

View reviewed changes

Dosant added 2 commits September 24, 2020 11:31

Merge branch 'master' of github.com:elastic/kibana into tl/bump

cb54748

fix index-pattern import

1c2389d

streamich approved these changes Sep 24, 2020

View reviewed changes

Dosant merged commit 89e1f08 into elastic:master Sep 24, 2020

Dosant added a commit to Dosant/kibana that referenced this pull request Sep 24, 2020

bump @testing-library (elastic#78270)

1f1906b

Dosant mentioned this pull request Sep 24, 2020

[7.x] bump @testing-library (#78270) #78418

Merged

Dosant added a commit that referenced this pull request Sep 24, 2020

bump @testing-library (#78270) (#78418)

03a50cf

Dosant mentioned this pull request Sep 29, 2020

@testing-library remove "pure" hack #78742

Merged

Conversation

Dosant commented Sep 23, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Uh oh!

Dosant left a comment

Choose a reason for hiding this comment

Uh oh!

Dosant Sep 23, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

mistic left a comment

Choose a reason for hiding this comment

Uh oh!

elasticmachine commented Sep 23, 2020

Uh oh!

weltenwort left a comment

Choose a reason for hiding this comment

Uh oh!

sorenlouv left a comment

Choose a reason for hiding this comment

Uh oh!

patrykkopycinski left a comment

Choose a reason for hiding this comment

Uh oh!

peteharverson left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

streamich left a comment

Choose a reason for hiding this comment

Uh oh!

kibanamachine commented Sep 29, 2020

💚 Build Succeeded

Metrics [docs]

async chunks size

page load bundle size

History

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

9 participants

Dosant commented Sep 23, 2020 •

edited

Loading

Dosant Sep 23, 2020 •

edited

Loading