Skip to content

Accessibility - Dashboard Edit Panel tests#78181

Merged
rashmivkulkarni merged 21 commits intoelastic:masterfrom
rashmivkulkarni:accessibility
Sep 22, 2020
Merged

Accessibility - Dashboard Edit Panel tests#78181
rashmivkulkarni merged 21 commits intoelastic:masterfrom
rashmivkulkarni:accessibility

Conversation

@rashmivkulkarni
Copy link
Copy Markdown
Contributor

Ref Meta issue: #51456
Fixes #60766

@rashmivkulkarni rashmivkulkarni added Feature:Dashboard Dashboard related features Team:QA Platform QA t// Project:Accessibility Team:Visualizations Team label for Lens, elastic-charts, Graph, legacy editors (TSVB, Visualize, Timelion) t// v8.0.0 release_note:skip Skip the PR/issue when compiling release notes v7.10.0 labels Sep 22, 2020
@elasticmachine
Copy link
Copy Markdown
Contributor

Pinging @elastic/kibana-qa (Team:QA)

@elasticmachine
Copy link
Copy Markdown
Contributor

Pinging @elastic/kibana-app (Team:KibanaApp)

@kibanamachine
Copy link
Copy Markdown
Contributor

💚 Build Succeeded

Build metrics

@kbn/optimizer bundle module count

id value diff baseline
advancedSettings 53 +53 -
alerts 26 +26 -
apm 1248 +1248 -
apmOss 6 +6 -
beatsManagement 304 +304 -
bfetch 20 +20 -
canvas 1194 +1194 -
charts 34 +34 -
cloud 6 +6 -
console 163 +163 -
core 562 +562 -
crossClusterReplication 160 +160 -
dashboard 171 +171 -
dashboardEnhanced 29 +29 -
dashboardMode 7 +7 -
data 567 +567 -
dataEnhanced 20 +20 -
devTools 20 +20 -
discover 254 +254 -
discoverEnhanced 11 +11 -
embeddable 95 +95 -
embeddableEnhanced 16 +16 -
enterpriseSearch 275 +275 -
esUiShared 229 +229 -
expressions 109 +109 -
features 11 +11 -
fileUpload 27 +27 -
globalSearch 22 +22 -
globalSearchBar 13 +13 -
globalSearchProviders 8 +8 -
graph 181 +181 -
grokdebugger 76 +76 -
home 213 +213 -
indexLifecycleManagement 205 +205 -
indexManagement 503 +503 -
indexPatternManagement 214 +214 -
infra 1096 +1096 -
ingestManager 548 +548 -
ingestPipelines 447 +447 -
inputControlVis 44 +44 -
inspector 65 +65 -
kibanaLegacy 124 +124 -
kibanaReact 290 +290 -
kibanaUtils 190 +190 -
lens 447 +447 -
licenseManagement 145 +145 -
licensing 25 +25 -
lists 128 +128 -
logstash 195 +195 -
management 45 +45 -
maps 694 +694 -
mapsLegacy 140 +140 -
mapsLegacyLicensing 4 +4 -
ml 1408 +1408 -
monitoring 619 +619 -
navigation 26 +26 -
newsfeed 10 +10 -
observability 90 +90 -
painlessLab 43 +43 -
regionMap 17 +17 -
remoteClusters 142 +142 -
reporting 46 +46 -
rollup 180 +180 -
savedObjects 46 +46 -
savedObjectsManagement 137 +137 -
searchprofiler 76 +76 -
security 455 +455 -
securitySolution 2006 +2006 -
share 38 +38 -
snapshotRestore 171 +171 -
spaces 227 +227 -
telemetry 23 +23 -
telemetryManagementSection 8 +8 -
tileMap 23 +23 -
timelion 105 +105 -
transform 503 +503 -
triggers_actions_ui 251 +251 -
uiActions 34 +34 -
uiActionsEnhanced 278 +278 -
upgradeAssistant 119 +119 -
uptime 513 +513 -
urlForwarding 11 +11 -
usageCollection 17 +17 -
visDefaultEditor 240 +240 -
visTypeMarkdown 23 +23 -
visTypeMetric 28 +28 -
visTypeTable 45 +45 -
visTypeTagcloud 26 +26 -
visTypeTimelion 48 +48 -
visTypeTimeseries 466 +466 -
visTypeVega 80 +80 -
visTypeVislib 276 +276 -
visTypeXy 4 +4 -
visualizations 135 +135 -
visualize 214 +214 -
watcher 227 +227 -
total +21113

async chunks size

id value diff baseline
advancedSettings 63.8KB +63.8KB -
apm 4.2MB ⚠️ +4.2MB -
beatsManagement 408.0KB ⚠️ +408.0KB -
canvas 1.4MB ⚠️ +1.4MB -
console 1.1MB ⚠️ +1.1MB -
crossClusterReplication 461.1KB ⚠️ +461.1KB -
devTools 6.5KB +6.5KB -
discover 437.2KB ⚠️ +437.2KB -
enterpriseSearch 504.1KB ⚠️ +504.1KB -
fileUpload 720.7KB ⚠️ +720.7KB -
graph 1.4MB ⚠️ +1.4MB -
grokdebugger 711.0KB ⚠️ +711.0KB -
home 568.1KB ⚠️ +568.1KB -
indexLifecycleManagement 228.5KB ⚠️ +228.5KB -
indexManagement 1.6MB ⚠️ +1.6MB -
indexPatternManagement 806.2KB ⚠️ +806.2KB -
infra 3.8MB ⚠️ +3.8MB -
ingestManager 1.1MB ⚠️ +1.1MB -
ingestPipelines 765.6KB ⚠️ +765.6KB -
kibanaLegacy 147.1KB +147.1KB -
lens 26.2KB +26.2KB -
licenseManagement 167.5KB +167.5KB -
logstash 216.9KB ⚠️ +216.9KB -
management 176.8KB +176.8KB -
maps 3.3MB ⚠️ +3.3MB -
ml 8.1MB ⚠️ +8.1MB -
monitoring 1.1MB ⚠️ +1.1MB -
observability 296.5KB ⚠️ +296.5KB -
painlessLab 182.0KB +182.0KB -
remoteClusters 374.0KB ⚠️ +374.0KB -
rollup 329.2KB ⚠️ +329.2KB -
savedObjectsManagement 204.2KB ⚠️ +204.2KB -
searchprofiler 714.8KB ⚠️ +714.8KB -
security 1.0MB ⚠️ +1.0MB -
securitySolution 10.1MB ⚠️ +10.1MB -
snapshotRestore 763.5KB ⚠️ +763.5KB -
spaces 45.9KB +45.9KB -
timelion 597.3KB ⚠️ +597.3KB -
transform 661.1KB ⚠️ +661.1KB -
triggers_actions_ui 961.5KB ⚠️ +961.5KB -
upgradeAssistant 322.3KB ⚠️ +322.3KB -
uptime 1.6MB ⚠️ +1.6MB -
visDefaultEditor 44.8KB +44.8KB -
visTypeMarkdown 1.9KB +1.9KB -
visTypeTable 6.6KB +6.6KB -
visTypeTimeseries 1.8MB ⚠️ +1.8MB -
visTypeVega 1.4MB ⚠️ +1.4MB -
visualize 414.7KB ⚠️ +414.7KB -
watcher 602.5KB ⚠️ +602.5KB -
total ⚠️ +55.8MB

miscellaneous assets size

id value diff baseline
apm 49.0KB +49.0KB -
enterpriseSearch 644.9KB ⚠️ +644.9KB -
kibanaLegacy 928.6KB ⚠️ +928.6KB -
maps 978.6KB ⚠️ +978.6KB -
securitySolution 326.0KB ⚠️ +326.0KB -
triggers_actions_ui 27.7KB +27.7KB -
total ⚠️ +2.9MB

page load bundle size

id value diff baseline
advancedSettings 981.4KB ⚠️ +981.4KB -
alerts 89.3KB +89.3KB -
apm 44.0KB +44.0KB -
apmOss 3.9KB +3.9KB -
beatsManagement 581.6KB ⚠️ +581.6KB -
bfetch 26.2KB +26.2KB -
canvas 1.3MB ⚠️ +1.3MB -
charts 486.6KB ⚠️ +486.6KB -
cloud 5.9KB +5.9KB -
console 30.3KB +30.3KB -
core 1.2MB ⚠️ +1.2MB -
crossClusterReplication 192.1KB +192.1KB -
dashboard 708.3KB ⚠️ +708.3KB -
dashboardEnhanced 185.9KB +185.9KB -
dashboardMode 150.4KB +150.4KB -
data 1.5MB ⚠️ +1.5MB -
dataEnhanced 177.1KB +177.1KB -
devTools 166.1KB +166.1KB -
discover 230.0KB ⚠️ +230.0KB -
discoverEnhanced 29.2KB +29.2KB -
embeddable 435.1KB ⚠️ +435.1KB -
embeddableEnhanced 40.4KB +40.4KB -
enterpriseSearch 23.2KB +23.2KB -
esUiShared 994.2KB ⚠️ +994.2KB -
expressions 346.6KB ⚠️ +346.6KB -
features 15.8KB +15.8KB -
fileUpload 9.4KB +9.4KB -
globalSearch 27.9KB +27.9KB -
globalSearchBar 27.9KB +27.9KB -
globalSearchProviders 10.3KB +10.3KB -
graph 15.8KB +15.8KB -
grokdebugger 11.4KB +11.4KB -
home 26.7KB +26.7KB -
indexLifecycleManagement 232.1KB ⚠️ +232.1KB -
indexManagement 263.2KB ⚠️ +263.2KB -
indexPatternManagement 136.0KB +136.0KB -
infra 277.4KB ⚠️ +277.4KB -
ingestManager 514.3KB ⚠️ +514.3KB -
ingestPipelines 32.7KB +32.7KB -
inputControlVis 296.2KB ⚠️ +296.2KB -
inspector 277.4KB ⚠️ +277.4KB -
kibanaLegacy 232.6KB ⚠️ +232.6KB -
kibanaReact 646.0KB ⚠️ +646.0KB -
kibanaUtils 471.7KB ⚠️ +471.7KB -
lens 1.1MB ⚠️ +1.1MB -
licenseManagement 26.3KB +26.3KB -
licensing 26.8KB +26.8KB -
lists 164.1KB +164.1KB -
logstash 180.1KB +180.1KB -
management 30.2KB +30.2KB -
maps 301.1KB ⚠️ +301.1KB -
mapsLegacy 957.9KB ⚠️ +957.9KB -
mapsLegacyLicensing 4.1KB +4.1KB -
ml 873.5KB ⚠️ +873.5KB -
monitoring 302.6KB ⚠️ +302.6KB -
navigation 164.7KB +164.7KB -
newsfeed 22.1KB +22.1KB -
observability 52.3KB +52.3KB -
painlessLab 161.0KB +161.0KB -
regionMap 445.6KB ⚠️ +445.6KB -
remoteClusters 35.4KB +35.4KB -
reporting 304.2KB ⚠️ +304.2KB -
rollup 223.1KB ⚠️ +223.1KB -
savedObjects 235.7KB ⚠️ +235.7KB -
savedObjectsManagement 225.9KB ⚠️ +225.9KB -
searchprofiler 50.8KB +50.8KB -
security 305.7KB ⚠️ +305.7KB -
securitySolution 793.4KB ⚠️ +793.4KB -
share 80.0KB +80.0KB -
snapshotRestore 62.6KB +62.6KB -
spaces 489.6KB ⚠️ +489.6KB -
telemetry 75.0KB +75.0KB -
telemetryManagementSection 26.9KB +26.9KB -
tileMap 457.2KB ⚠️ +457.2KB -
timelion 14.5KB +14.5KB -
transform 25.5KB +25.5KB -
triggers_actions_ui 287.4KB ⚠️ +287.4KB -
uiActions 223.4KB ⚠️ +223.4KB -
uiActionsEnhanced 380.1KB ⚠️ +380.1KB -
upgradeAssistant 64.5KB +64.5KB -
uptime 25.1KB +25.1KB -
urlForwarding 17.1KB +17.1KB -
usageCollection 24.2KB +24.2KB -
visDefaultEditor 539.5KB ⚠️ +539.5KB -
visTypeMarkdown 28.9KB +28.9KB -
visTypeMetric 194.1KB +194.1KB -
visTypeTable 220.6KB ⚠️ +220.6KB -
visTypeTagcloud 307.8KB ⚠️ +307.8KB -
visTypeTimelion 325.7KB ⚠️ +325.7KB -
visTypeTimeseries 279.7KB ⚠️ +279.7KB -
visTypeVega 277.5KB ⚠️ +277.5KB -
visTypeVislib 951.1KB ⚠️ +951.1KB -
visTypeXy 5.1KB +5.1KB -
visualizations 412.5KB ⚠️ +412.5KB -
visualize 41.3KB +41.3KB -
watcher 28.8KB +28.8KB -
total ⚠️ +25.8MB

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@rashmivkulkarni rashmivkulkarni requested review from bhavyarm and flash1293 and removed request for bhavyarm September 22, 2020 18:53
@rashmivkulkarni rashmivkulkarni self-assigned this Sep 22, 2020
Copy link
Copy Markdown
Contributor

@bhavyarm bhavyarm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rashmivkulkarni rashmivkulkarni merged commit da1b319 into elastic:master Sep 22, 2020
@kibanamachine
Copy link
Copy Markdown
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 78181 or prevent reminders by adding the backport:skip label.

@kibanamachine kibanamachine added the backport missing Added to PRs automatically when the are determined to be missing a backport. label Sep 24, 2020
@kibanamachine
Copy link
Copy Markdown
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 78181 or prevent reminders by adding the backport:skip label.

rashmivkulkarni added a commit to rashmivkulkarni/kibana that referenced this pull request Sep 25, 2020
* accessibility tests for dashboard panel

* added back the skipped test as it is still required to pass through th ea11ySnapshot

* wip dashboard panel tests

* wip- accessibility

* wip -accessibility

* wip accessibility

* accessibility tests for dashboard edit panel

* accessibility tests

* removed the unused variables

* dashboard_edit_panel tests

* added a comment

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
@kibanamachine kibanamachine removed the backport missing Added to PRs automatically when the are determined to be missing a backport. label Sep 26, 2020
rashmivkulkarni added a commit that referenced this pull request Sep 26, 2020
* accessibility tests for dashboard panel

* added back the skipped test as it is still required to pass through th ea11ySnapshot

* wip dashboard panel tests

* wip- accessibility

* wip -accessibility

* wip accessibility

* accessibility tests for dashboard edit panel

* accessibility tests

* removed the unused variables

* dashboard_edit_panel tests

* added a comment

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Feature:Dashboard Dashboard related features Project:Accessibility release_note:skip Skip the PR/issue when compiling release notes Team:QA Platform QA t// Team:Visualizations Team label for Lens, elastic-charts, Graph, legacy editors (TSVB, Visualize, Timelion) t// v7.10.0 v8.0.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add a11y dashboard panel tests

5 participants