Code-split kibanaReact & kibanaUtils#78140
Merged
Dosant merged 5 commits intoelastic:masterfrom Sep 23, 2020
Merged
Conversation
streamich
approved these changes
Sep 22, 2020
Contributor
streamich
left a comment
There was a problem hiding this comment.
Code LGTM.
By any chance do you have handy a screenshot of bundle analyzer output after this change?
Contributor
Author
|
@streamich , after the changes: KibanaReact
KibanaUtils
|
Contributor
|
Pinging @elastic/kibana-app-arch (Team:AppArch) |
Dosant
commented
Sep 22, 2020
Contributor
Author
There was a problem hiding this comment.
I struggled with making this test work with enzyme for quite a while. Ended up with re-imlementing it with simpler @testing-library
6630492 to
3255005
Compare
Dosant
commented
Sep 23, 2020
| onFocus={[Function]} | ||
| > | ||
| <div | ||
| className="react-monaco-editor-container" |
Contributor
Author
There was a problem hiding this comment.
🤷♂️ this is autogenerated test. Didn't find a way how to wait for editor here.
timroes
approved these changes
Sep 23, 2020
Contributor
timroes
left a comment
There was a problem hiding this comment.
Only looked at Kibana App code. Code seems good to me
crob611
approved these changes
Sep 23, 2020
Contributor
crob611
left a comment
There was a problem hiding this comment.
Code looks good to me but one little bit that needs to be cleaned up before merging though. See below 👇
Contributor
💚 Build SucceededBuild metricsasync chunks size
page load bundle size
distributable file count
History
To update your PR or re-run it, just comment with: |
Dosant
added a commit
to Dosant/kibana
that referenced
this pull request
Sep 23, 2020
Dosant
added a commit
that referenced
this pull request
Sep 24, 2020
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This addresses most heavy things in
kibanaReact&kibanaUtils:Lodash imports: (I know that there are parallel efforts on addressing- reverted this because of: [shared-ui-deps] use a single global version of lodash #78100lodashglobally, but I was not sure how far those away, so decided to clean this up locally)Notes:
enzymeis pretty ugly with suspense. After fighting it for sometime I re-implemented failing tests withtesting-library