Skip to content

[ILM] Remove frozen phase#77877

Merged
jloleysens merged 2 commits intoelastic:masterfrom
jloleysens:ilm/remove-frozen-phase
Sep 21, 2020
Merged

[ILM] Remove frozen phase#77877
jloleysens merged 2 commits intoelastic:masterfrom
jloleysens:ilm/remove-frozen-phase

Conversation

@jloleysens
Copy link
Copy Markdown
Contributor

@jloleysens jloleysens commented Sep 18, 2020 •
edited
Loading

Summary

After elastic/elasticsearch#62403 was merged, this PR removes the corresponding ILM frozen phase UI.

How to test

  1. Start Kibana on basic license
  2. Go to index lifecycle management
  3. Create a policy with the available form controls for all available phases
  4. The form should work as usual, except there should be no option to activate or configure anything regarding a frozen phase.

Additional context

@jloleysens jloleysens added Feature:ILM v8.0.0 Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more t// release_note:skip Skip the PR/issue when compiling release notes v7.10.0 labels Sep 18, 2020
@jloleysens jloleysens requested a review from a team as a code owner September 18, 2020 12:11
@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Sep 18, 2020

Pinging @elastic/es-ui (Team:Elasticsearch UI)

yuliacech
yuliacech approved these changes Sep 18, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@yuliacech yuliacech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @jloleysens, great job on removing Frozen phase (it's a pity it has to go though).
Tested locally, everything works! I searched for frozen and found following usage still in the code that you might want to check:

  • /public/extend_index_management/index.js line 202 has a filter option for frozen phase
  • snapshots for index management extension
  • NodeDataRole type in /common/types/api has data_frozen

@jloleysens
Copy link
Copy Markdown
Contributor Author

jloleysens commented Sep 21, 2020

@elasticmachine merge upstream

@kibanamachine
Copy link
Copy Markdown
Contributor

kibanamachine commented Sep 21, 2020

💚 Build Succeeded

Build metrics

@kbn/optimizer bundle module count

id value diff baseline
indexLifecycleManagement 205 -2 207

async chunks size

id value diff baseline
indexLifecycleManagement 228.0KB -14.3KB 242.4KB

page load bundle size

id value diff baseline
indexLifecycleManagement 232.2KB -309.0B 232.5KB

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@jloleysens jloleysens merged commit 01ef387 into elastic:master Sep 21, 2020
@jloleysens
Copy link
Copy Markdown
Contributor Author

jloleysens commented Sep 21, 2020

Thanks for the review @yuliacech !

Noted; those entries refer to the "frozen" indices as a result of the "freeze" action. That functionality is for adding a label next to those index names in index management so we want them to stick around.

@jloleysens jloleysens deleted the ilm/remove-frozen-phase branch September 21, 2020 10:27
@jloleysens jloleysens mentioned this pull request Sep 21, 2020
Merged
jloleysens added a commit to jloleysens/kibana that referenced this pull request Sep 21, 2020
@jloleysens @elasticmachine
Round #1 of removing frozen phase UI and server code (elastic#77877)
b7c62ff 
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
jloleysens added a commit that referenced this pull request Sep 21, 2020
@jloleysens @elasticmachine
Round #1 of removing frozen phase UI and server code (#77877) (#77990)
2125d61 
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
@cjcenizal cjcenizal mentioned this pull request Feb 11, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@yuliacech yuliacech yuliacech approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Feature:ILM release_note:skip Skip the PR/issue when compiling release notes Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more t// v7.10.0 v8.0.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@jloleysens @elasticmachine @kibanamachine @yuliacech