Accessibility dashboard edit panel tests #77829
Merged
rashmivkulkarni merged 17 commits intoelastic:masterfrom Sep 21, 2020
Merged
Accessibility dashboard edit panel tests #77829rashmivkulkarni merged 17 commits intoelastic:masterfrom
rashmivkulkarni merged 17 commits intoelastic:masterfrom
Conversation
Contributor
|
Pinging @elastic/kibana-app (Team:KibanaApp) |
Contributor
Author
|
@elasticmachine merge upstream |
Contributor
💚 Build SucceededBuild metrics
History
To update your PR or re-run it, just comment with: |
77 tasks
myasonik
approved these changes
Sep 21, 2020
Contributor
myasonik
left a comment
There was a problem hiding this comment.
I didn't run through the pages but the code seems ok 👍
Don't forget to add all the appropriate labels and whatnot to the PR!
Contributor
|
Pinging @elastic/kibana-qa (Team:QA) |
rashmivkulkarni
added a commit
to rashmivkulkarni/kibana
that referenced
this pull request
Sep 21, 2020
* accessibility tests for dashboard panel * added back the skipped test as it is still required to pass through th ea11ySnapshot * wip dashboard panel tests * wip- accessibility * wip -accessibility * wip accessibility * accessibility tests for dashboard edit panel * accessibility tests * removed the unused variables Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
Contributor
Author
|
@elasticmachine merge upstream |
Contributor
|
ignoring request to update branch, pull request is closed |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ref Meta issue: #51456
Fixes #60766