[RUM Dashboard] User experience metrics#77384
Merged
shahzad31 merged 16 commits intoelastic:masterfrom Sep 16, 2020
Merged
Conversation
Contributor
|
Pinging @elastic/apm-ui (Team:apm) |
|
@shahzad31 - inconsistency in labels. "No of long task" should be "tasks". This matches the third label you have "Sum of long tasks". |
Contributor
justinkambic
left a comment
There was a problem hiding this comment.
Leaving review for code updates, I will perform a functional review separately.
x-pack/plugins/apm/public/components/app/RumDashboard/CoreVitals/translations.ts
Outdated
Show resolved
Hide resolved
x-pack/plugins/apm/public/components/app/RumDashboard/CoreVitals/translations.ts
Outdated
Show resolved
Hide resolved
x-pack/plugins/apm/public/components/app/RumDashboard/UXMetrics/KeyUXMetrics.tsx
Outdated
Show resolved
Hide resolved
x-pack/plugins/apm/public/components/app/RumDashboard/UXMetrics/KeyUXMetrics.tsx
Outdated
Show resolved
Hide resolved
x-pack/plugins/apm/public/components/app/RumDashboard/UXMetrics/KeyUXMetrics.tsx
Outdated
Show resolved
Hide resolved
justinkambic
approved these changes
Sep 15, 2020
Contributor
justinkambic
left a comment
There was a problem hiding this comment.
Thank you for addressing that feedback. I also tested this out locally and it is working as I'd expect.
LGTM
smith
approved these changes
Sep 15, 2020
formgeist
reviewed
Sep 16, 2020
Contributor
formgeist
left a comment
There was a problem hiding this comment.
A small visual suggested fix to the titling.
x-pack/plugins/apm/public/components/app/RumDashboard/UXMetrics/index.tsx
Show resolved
Hide resolved
Contributor
Author
|
@elasticmachine merge upstream |
Contributor
💚 Build SucceededBuild metrics@kbn/optimizer bundle module count
async chunks size
distributable file count
History
To update your PR or re-run it, just comment with: |
gmmorris
added a commit
to gmmorris/kibana
that referenced
this pull request
Sep 16, 2020
* master: [RUM Dashboard] User experience metrics (elastic#77384) Fixing service maps API test (elastic#77586)
shahzad31
added a commit
to shahzad31/kibana
that referenced
this pull request
Sep 17, 2020
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
shahzad31
added a commit
that referenced
this pull request
Sep 17, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #77204
Added user experience metrics