Skip to content

[Security Solution] Options to select index patterns#77192

Merged
XavierM merged 108 commits intoelastic:masterfrom
XavierM:sourcerer-offshoot
Sep 23, 2020
Merged

[Security Solution] Options to select index patterns#77192
XavierM merged 108 commits intoelastic:masterfrom
XavierM:sourcerer-offshoot

Conversation

@XavierM
Copy link
Copy Markdown
Contributor

@XavierM XavierM commented Sep 10, 2020

Summary

  • Write a script to get the latest field from beat documentation + create a hashtable of these fields to simplify code in our query index search strategy
  • remove our graphql query index field to a search strategy
  • get all the kibana index pattern when loading our app
  • refactor sourcerer to only use redux
  • host pages use sourcererScope instead of useWithSource
  • network pages use sourcererScope instead of useWithSource
  • overview pages use sourcererScope instead of useWithSource
  • timeline flyout use sourcererScope instead of useWithSource
  • detections should also use sourcererScope instead of useWithSource
  • I did remove some unused code but we will create another PR to remove all the graphql who are not used anymore
  • test and test and test

image

image

Checklist

patrykkopycinski and others added 5 commits September 23, 2020 08:32
…shoot

# Conflicts:
#	x-pack/plugins/security_solution/public/common/containers/events/last_event_time/index.ts
#	x-pack/plugins/security_solution/public/hosts/containers/hosts/first_last_seen/index.tsx
#	x-pack/plugins/security_solution/public/hosts/containers/uncommon_processes/index.tsx
#	x-pack/plugins/security_solution/public/overview/containers/overview_host/index.tsx
#	x-pack/plugins/security_solution/public/timelines/containers/index.tsx
@elastic elastic deleted a comment from kibanamachine Sep 23, 2020
Copy link
Copy Markdown
Contributor

@angorayc angorayc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ran and tested locally, looks good to me! Thank you @XavierM

Copy link
Copy Markdown
Contributor

@patrykkopycinski patrykkopycinski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😍 💪 🚀 That's AWESOME @XavierM @stephmilovic !!!

@kibanamachine
Copy link
Copy Markdown
Contributor

💚 Build Succeeded

Build metrics

@kbn/optimizer bundle module count

id value diff baseline
securitySolution 1971 +6 1965

async chunks size

id value diff baseline
securitySolution 10.2MB -42.1KB 10.2MB

page load bundle size

id value diff baseline
data 1.5MB +930.0B 1.5MB
securitySolution 810.8KB +17.5KB 793.4KB
total +18.4KB

distributable file count

id value diff baseline
default 45864 -3 45867

Saved Objects .kibana field count

id value diff baseline
siem-ui-timeline 90 +1 89

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@XavierM XavierM merged commit 94a4e38 into elastic:master Sep 23, 2020
XavierM added a commit to XavierM/kibana that referenced this pull request Sep 24, 2020
* init commit

* lots of cleanup

* starting on tests... problems

* Ready for review

* remove sample data

* remove comment and fix type

* pr changes

* fix type

* scratchy

* sourcerer in timeline

* sourcerer in timeline

* wip

* moving to redux

* working on types

* fixed

* more adjustments, tests fixed

* FF off

* pr ready

* renaming

* url state working, hoc not working

* url state working for timeline and default scope

* script to build fields for beat doc

* refactor sourcerer

* refactor host to useSourcerer

* refactor network to useSourcerer

* refactor overview  to useSourcerer

* refactor detections to useSourcerer

* wip for timelines to remove all useSource

* wip indexes timeline

* do component tests

* start container tests

* start container tests

* update selection widget of index patterns + remove last useWithSource

* add indexeNames in network kpi

* fix type errors

* fix type

* missing merge master

* get existing index from config file

* fixing broken tests

* add saving button to avoid to many queries to be aborted

* reducer timeline tests broke

* need to rewind

* much better

* timeline saving index names + clean up url state to only manage default

* more test fixing

* more test changes

* remove all the useWithSource + deprecated the graphql until we delete it in a new PR + delete all the beat doc

* default timeline to all index when creation + filter index patterns to make sure you do not add one who we do not know

* fix types

* test for stateful timeline render

* we should not have change that

* no chnages + snapshot

* fix test + bugs from review

* fix uncommon processes indexNames

* review III

* change design for main page of the sourcerer from design

* bug fixes when opening old timeline + implementation of new design

* fix circular deps

* remove unused attributes for event details

* design cleanup

* fix api integration test with the new search strategy

* add reset + manage accordion state

* fix bugs + types issues

* cleanup

* update docs

* review -> remove tooltip when popover is open

* cypress fixing

* fix for ml_condition_links and url_state cypress tests

* add cy wait for race condition in pagination tests

* missing plumbing kpi host

Co-authored-by: Steph Milovic <stephanie.milovic@elastic.co>
Co-authored-by: Patryk Kopycinski <contact@patrykkopycinski.com>
XavierM added a commit that referenced this pull request Sep 24, 2020
* init commit

* lots of cleanup

* starting on tests... problems

* Ready for review

* remove sample data

* remove comment and fix type

* pr changes

* fix type

* scratchy

* sourcerer in timeline

* sourcerer in timeline

* wip

* moving to redux

* working on types

* fixed

* more adjustments, tests fixed

* FF off

* pr ready

* renaming

* url state working, hoc not working

* url state working for timeline and default scope

* script to build fields for beat doc

* refactor sourcerer

* refactor host to useSourcerer

* refactor network to useSourcerer

* refactor overview  to useSourcerer

* refactor detections to useSourcerer

* wip for timelines to remove all useSource

* wip indexes timeline

* do component tests

* start container tests

* start container tests

* update selection widget of index patterns + remove last useWithSource

* add indexeNames in network kpi

* fix type errors

* fix type

* missing merge master

* get existing index from config file

* fixing broken tests

* add saving button to avoid to many queries to be aborted

* reducer timeline tests broke

* need to rewind

* much better

* timeline saving index names + clean up url state to only manage default

* more test fixing

* more test changes

* remove all the useWithSource + deprecated the graphql until we delete it in a new PR + delete all the beat doc

* default timeline to all index when creation + filter index patterns to make sure you do not add one who we do not know

* fix types

* test for stateful timeline render

* we should not have change that

* no chnages + snapshot

* fix test + bugs from review

* fix uncommon processes indexNames

* review III

* change design for main page of the sourcerer from design

* bug fixes when opening old timeline + implementation of new design

* fix circular deps

* remove unused attributes for event details

* design cleanup

* fix api integration test with the new search strategy

* add reset + manage accordion state

* fix bugs + types issues

* cleanup

* update docs

* review -> remove tooltip when popover is open

* cypress fixing

* fix for ml_condition_links and url_state cypress tests

* add cy wait for race condition in pagination tests

* missing plumbing kpi host

Co-authored-by: Steph Milovic <stephanie.milovic@elastic.co>
Co-authored-by: Patryk Kopycinski <contact@patrykkopycinski.com>

Co-authored-by: Steph Milovic <stephanie.milovic@elastic.co>
Co-authored-by: Patryk Kopycinski <contact@patrykkopycinski.com>
@MindyRS MindyRS added the Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. label Sep 23, 2021
@elasticmachine
Copy link
Copy Markdown
Contributor

Pinging @elastic/security-solution (Team: SecuritySolution)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

release_note:skip Skip the PR/issue when compiling release notes Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. Team:SIEM v7.10.0 v8.0.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.