[Reporting] rename interfaces to align with task manager integration#76716
Merged
tsullivan merged 8 commits intoelastic:masterfrom Sep 4, 2020
Merged
Conversation
Contributor
|
Pinging @elastic/kibana-reporting-services (Team:Reporting Services) |
joelgriffith
reviewed
Sep 3, 2020
|
|
||
| import { cryptoFactory } from '../../lib'; | ||
| import { CreateJobFn, ScheduleTaskFnFactory } from '../../types'; | ||
| import { CreateJobFn, CreateJobFnFactory } from '../../types'; |
Contributor
There was a problem hiding this comment.
WDYT about keeping the task nomenclature here? CreateTaskFnFactory?
joelgriffith
suggested changes
Sep 3, 2020
joelgriffith
approved these changes
Sep 3, 2020
Contributor
joelgriffith
left a comment
There was a problem hiding this comment.
LGTM, seems to align well with the diagram you shared
7 tasks
Contributor
💚 Build SucceededBuild metrics
History
To update your PR or re-run it, just comment with: |
tsullivan
added a commit
to tsullivan/kibana
that referenced
this pull request
Sep 4, 2020
…elastic#76716) * [Reporting] rename interfaces for schedule task * move screenshot types to their local * organize imports * remove schedule terminology * revert comment * fix ts * add newline
jloleysens
added a commit
to jloleysens/kibana
that referenced
this pull request
Sep 4, 2020
…rok/new-patterns-component-use-array * 'master' of github.com:elastic/kibana: (75 commits) Remove legacy ui-apps-mixin (elastic#76604) remove unused test_utils (elastic#76528) [ML] Functional tests - add UI permission tests (elastic#76368) [APM] @ts-error -> @ts-expect-error (elastic#76492) [APM] Avoid negative offset for error marker on timeline (elastic#76638) [Reporting] rename interfaces to align with task manager integration (elastic#76716) Revert back ESO migration for alerting, added try/catch logic to avoid failing Kibana on start (elastic#76220) Test reverting "Add plugin status API (elastic#75819)" (elastic#76707) [Security Solution][Detections] Removes ML Job Settings SIEM copy and fixes link to ML app for creating custom jobs (elastic#76595) [Maps] remove region/coordinate-maps visualizations from sample data (elastic#76399) [DOCS] Dashboard-first docs refresh (elastic#76194) Updated ServiceNow description in docs and actions management UI to contains correct info (elastic#76344) [DOCS] Identifies cloud settings in reporting (elastic#76691) [Security Solution] Refactor timeline details to use search strategy (elastic#75591) es-archiver: Drop invalid index settings, support --query flag (elastic#76522) [DOCS] Identifies graph settings available on cloud (elastic#76661) Add more info about a11y tests (elastic#76045) [data.search.SearchSource] Remove legacy ES client APIs. (elastic#75943) [release notes] automatically retry on Github API 5xx errors (elastic#76447) [es_ui_shared] Fix eslint exhaustive deps rule (elastic#76392) ...
tsullivan
added a commit
that referenced
this pull request
Sep 5, 2020
…ation (#76716) (#76737) * [Reporting] rename interfaces to align with task manager integration (#76716) * [Reporting] rename interfaces for schedule task * move screenshot types to their local * organize imports * remove schedule terminology * revert comment * fix ts * add newline * coment * fix tests
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR sweeps through the Reporting server code and renames interfaces to align with the architectural design of #64853
Reasoning behind the changes: we should get away from the "scheduling" terminology as the name of the process where user input data gets converted into a report document.
When a report executes, it relies on a "job" that been "created" to contain a "payload." The payload is the user input + a string of encrypted headers. Scheduled reports will rely on the created job as well: it will be the task instance parameters.
Therefore, "creating a job" is different from "scheduling a task."
This PR goes back to naming the interfaces of this process to "create job" terminology.