Merged
Conversation
mshustov
commented
Sep 3, 2020
packages/kbn-test/src/functional_test_runner/lib/config/read_config_file.ts
Outdated
Show resolved
Hide resolved
Contributor
|
Pinging @elastic/kibana-platform (Team:Platform) |
pgayvallet
approved these changes
Sep 3, 2020
Comment on lines
-44
to
-50
| // transform deprecated plugin settings | ||
| for (let i = 0; i < pluginSpecs.length; i++) { | ||
| const spec = pluginSpecs[i]; | ||
| const transform = await getTransform(spec); | ||
| const prefix = spec.getConfigPrefix(); | ||
|
|
||
| // nested plugin prefixes (a.b) translate to nested objects |
Contributor
There was a problem hiding this comment.
So glad this finally goes away.
Contributor
💛 Build succeeded, but was flaky
Test FailuresChrome X-Pack UI Functional Tests.x-pack/test/functional/apps/discover/async_scripted_fields·js.discover async search with scripted fields query return results with valid scripted fieldStandard OutStack TraceBuild metricsoss distributable file count
distributable file count
History
To update your PR or re-run it, just comment with: |
mshustov
added a commit
to mshustov/kibana
that referenced
this pull request
Sep 4, 2020
* inline deprecations in kbn-test * remove LP deprecations * remove test * inline log call * remove unnecessary deprecations for the test config
2 tasks
mshustov
added a commit
that referenced
this pull request
Sep 4, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The remaining legacy plugins do not deprecation mechanism, therefore we can remove it as a part of the legacy platform cleanup.