[ILM] TS conversion of Index Management plugin extension#76517
Merged
yuliacech merged 5 commits intoelastic:masterfrom Sep 4, 2020
Merged
[ILM] TS conversion of Index Management plugin extension#76517yuliacech merged 5 commits intoelastic:masterfrom
yuliacech merged 5 commits intoelastic:masterfrom
Conversation
Contributor
|
Pinging @elastic/es-ui (Team:Elasticsearch UI) |
Contributor
Author
|
@elasticmachine merge upstream |
Contributor
Author
|
@elasticmachine merge upstream |
Contributor
Author
|
Hi @alisonelizabeth , |
Contributor
💛 Build succeeded, but was flaky
Test FailuresAccessibility Tests.test/accessibility/apps/discover·ts.Discover Load a new search from the panelStandard OutStack TraceBuild metricsasync chunks size
page load bundle size
History
To update your PR or re-run it, just comment with: |
alisonelizabeth
approved these changes
Sep 3, 2020
Contributor
alisonelizabeth
left a comment
There was a problem hiding this comment.
Great work @yuliacech! I did not retest, but latest changes LGTM.
I couldn't import from server folder in IM to public folder in ILM, so I moved the type to common folder in IM. What do you think?
👍 Makes sense
yuliacech
added a commit
that referenced
this pull request
Sep 4, 2020
…6757) * [ILM] TS conversion of Index Management plugin extension * [ILM] Implement review suggestions * [ILM] Fix jest test Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com> Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
14 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
(replaces #76308)
This PR converts Index Management plugin extension to TypeScript as an ongoing effort of converting the ILM plugin #74271. No UI/UX changes were made in this PR. To test for any regression, navigate to Index Management plugin and check following features in the Indices tab:
Todo
After this PR and policies table conversion PR #76006 are both merged, a follow-up PR will convert all the remaining js files, such as jest tests, services and helpers, also any remaining
anytypes will be cleaned up to complete #74271