Skip to content

[Ingest Manager] Add cacheClear & cacheDelete methods#76306

Merged
jfsiii merged 1 commit intoelastic:masterfrom
jfsiii:68890-add-cache-invalidation-tools
Aug 31, 2020
Merged

[Ingest Manager] Add cacheClear & cacheDelete methods#76306
jfsiii merged 1 commit intoelastic:masterfrom
jfsiii:68890-add-cache-invalidation-tools

Conversation

@jfsiii
Copy link
Copy Markdown
Contributor

@jfsiii jfsiii commented Aug 31, 2020

Summary

There are currently no cache invalidation/reduction methods for the EPM asset/archive cache. Add cacheDelete to remove one items and cacheClear to remove all.

We haven't needed them until now but cacheDelete would be useful for #68890

cacheClear doesn't have an explicit PR/issue afaik but I thought it'd be nice to have the ability to clear/purge without a Kibana restart

@jfsiii jfsiii requested a review from a team August 31, 2020 16:33
@botelastic botelastic bot added the Team:Fleet Team label for Observability Data Collection Fleet team label Aug 31, 2020
@elasticmachine
Copy link
Copy Markdown
Contributor

Pinging @elastic/ingest-management (Team:Ingest Management)

@jfsiii jfsiii self-assigned this Aug 31, 2020
@jfsiii jfsiii added the release_note:skip Skip the PR/issue when compiling release notes label Aug 31, 2020
@nchaulet
Copy link
Copy Markdown
Member

@jfsiii How this is going to work on a multiple instance Kibana setup?

@jfsiii
Copy link
Copy Markdown
Contributor Author

jfsiii commented Aug 31, 2020

@nchaulet It's got the same flaws as the current approach does for get, set, etc. This just adds two more functions to remove item(s) from that cache

As I said, I see cacheDelete being used in a service as part of #68890

@kibanamachine
Copy link
Copy Markdown
Contributor

💚 Build Succeeded

Build metrics

✅ unchanged

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@kibanamachine
Copy link
Copy Markdown
Contributor

Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync.

@kibanamachine kibanamachine added the backport missing Added to PRs automatically when the are determined to be missing a backport. label Sep 2, 2020
@kibanamachine kibanamachine removed the backport missing Added to PRs automatically when the are determined to be missing a backport. label Sep 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

release_note:skip Skip the PR/issue when compiling release notes Team:Fleet Team label for Observability Data Collection Fleet team v7.10.0 v8.0.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants