[ML] Remove "Are you sure" from filter lists#76180
Merged
lcawl merged 3 commits intoelastic:masterfrom Aug 31, 2020
Merged
Conversation
Contributor
|
Pinging @elastic/ml-ui (:ml) |
Member
Author
|
NOTE: The guidelines (https://elastic.github.io/eui/#/layout/modal/guidelines) also show an example like this for the singular case:
... so if we want to go that route for "Delete filter list 'myfilterlist'", that's fine by me too. |
Member
Author
|
@elasticmachine merge upstream |
Contributor
💚 Build SucceededBuild metricsasync chunks size
History
To update your PR or re-run it, just comment with: |
lcawl
added a commit
to lcawl/kibana
that referenced
this pull request
Aug 31, 2020
lcawl
added a commit
that referenced
this pull request
Aug 31, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Per https://elastic.github.io/eui/#/guidelines/writing, we should avoid using "Are you sure" in our UI messages. This PR cleans up some machine learning "delete filter" UI text.
Checklist
Screenshots (Before)
Delete a filter list:
Delete multiple filter lists:
Screenshots (After)
Delete a filter list:
Delete multiple filter lists: