Delete src/legacy/ui/public folder#76085
Merged
pgayvallet merged 12 commits intoelastic:masterfrom Sep 1, 2020
Merged
Conversation
2 tasks
Contributor
|
Pinging @elastic/kibana-platform (Team:Platform) |
pgayvallet
commented
Aug 31, 2020
Comment on lines
-25
to
-27
| npSetup.plugins.visualizations.createReactVisualization({ | ||
| name: 'self_changing_vis', | ||
| title: 'Self Changing Vis', |
Contributor
Author
There was a problem hiding this comment.
Remains from before this test plugin was migrated to KP. The file was unused (the test component is now registered from test/plugin_functional/plugins/kbn_tp_custom_visualizations/public/plugin.ts)
Comment on lines
44
to
52
|
|
||
| const indexPattern = new StubIndexPattern( | ||
| 'logstash-*', | ||
| (cfg) => cfg, | ||
| 'time', | ||
| fields, | ||
| npSetup.core | ||
| ); | ||
| const indexPattern = new StubIndexPattern('logstash-*', (cfg) => cfg, 'time', fields, { | ||
| uiSettings: uiSettingSetupMock, | ||
| }); | ||
|
|
Contributor
Author
There was a problem hiding this comment.
This is the only actual code change of the PR. The StubIndexPattern is only accessing uiSettings API, so I created an inline mock to replace the '../legacy/ui/public/new_platform/new_platform.karma_mock' import.
Contributor
|
Pinging @elastic/apm-ui (Team:apm) |
lizozom
approved these changes
Aug 31, 2020
Contributor
lizozom
left a comment
There was a problem hiding this comment.
Code owner changes are testing mocks only.
LGTM.
cjcenizal
approved these changes
Aug 31, 2020
Contributor
cjcenizal
left a comment
There was a problem hiding this comment.
Removal of unneeded ui/new_platform and ui/i18n mocks from ES UI Jest tests LGTM.
kindsun
approved these changes
Aug 31, 2020
Contributor
kindsun
left a comment
There was a problem hiding this comment.
Maps lgtm! Thanks for the clean up 🙇
- Code review
kertal
approved these changes
Aug 31, 2020
Member
kertal
left a comment
There was a problem hiding this comment.
25k LOC less 🥳. KibanaApp code owner review, just test files were modified, LGTM, didn't test
cchaos
suggested changes
Aug 31, 2020
joshdover
approved these changes
Aug 31, 2020
cchaos
approved these changes
Aug 31, 2020
Contributor
cchaos
left a comment
There was a problem hiding this comment.
Thanks. SASS changes LGTM 👍
Contributor
💚 Build SucceededBuild metricsasync chunks size
History
To update your PR or re-run it, just comment with: |
pgayvallet
added a commit
to pgayvallet/kibana
that referenced
this pull request
Sep 1, 2020
* delete src/legacy/ui/public folder
* remove jest.mock('ui/XXX'); from tests
* adapt stubbedLogstashIndexPatternService
* remove delete keys from translation files
* fix types import with Capabilities
* remove legacy test utils
* remove dead file referencing ui/newPlatform
* move saved-object-finder styles to timelion plugin
# Conflicts:
# src/legacy/ui/public/new_platform/new_platform.test.mocks.ts
# src/legacy/ui/public/new_platform/new_platform.ts
# src/test_utils/public/no_digest_promises.js
# x-pack/plugins/snapshot_restore/__jest__/client_integration/home.test.ts
# x-pack/plugins/snapshot_restore/__jest__/client_integration/policy_edit.test.ts
# x-pack/plugins/snapshot_restore/__jest__/client_integration/repository_add.test.ts
# x-pack/plugins/snapshot_restore/__jest__/client_integration/repository_edit.test.ts
pgayvallet
added a commit
that referenced
this pull request
Sep 1, 2020
* Delete src/legacy/ui/public folder (#76085) * delete src/legacy/ui/public folder * remove jest.mock('ui/XXX'); from tests * adapt stubbedLogstashIndexPatternService * remove delete keys from translation files * fix types import with Capabilities * remove legacy test utils * remove dead file referencing ui/newPlatform * move saved-object-finder styles to timelion plugin # Conflicts: # src/legacy/ui/public/new_platform/new_platform.test.mocks.ts # src/legacy/ui/public/new_platform/new_platform.ts # src/test_utils/public/no_digest_promises.js # x-pack/plugins/snapshot_restore/__jest__/client_integration/home.test.ts # x-pack/plugins/snapshot_restore/__jest__/client_integration/policy_edit.test.ts # x-pack/plugins/snapshot_restore/__jest__/client_integration/repository_add.test.ts # x-pack/plugins/snapshot_restore/__jest__/client_integration/repository_edit.test.ts * fix 7.x code * restore legacy docLinks file
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
13 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
All in title. Delete the
src/legacy/ui/publicfolder, that is no longer used by any code.src/legacy/ui/publicjest.mock('ui/XXX')usages in test filesui/*moduleNameMapper from jest configs"ui/*"from tsconfig's pathsCapabilitiesfromcore/typesinstead ofui/capabilities