chore(NA): add elastic prefix to eslint-config-kibana#76059
Merged
mistic merged 4 commits intoelastic:masterfrom Aug 31, 2020
Merged
chore(NA): add elastic prefix to eslint-config-kibana#76059mistic merged 4 commits intoelastic:masterfrom
mistic merged 4 commits intoelastic:masterfrom
Conversation
Contributor
|
Pinging @elastic/kibana-operations (Team:Operations) |
spalger
suggested changes
Aug 27, 2020
Contributor
spalger
left a comment
There was a problem hiding this comment.
Looks like you missed a reference in packages/kbn-plugin-generator/template/.eslintrc.js.ejs
spalger
approved these changes
Aug 27, 2020
Contributor
spalger
left a comment
There was a problem hiding this comment.
Oh, I'm wrong, that reference is to the @elastic/* package name
…r-eslint-config-kibana
Contributor
Author
|
@elasticmachine merge upstream |
tylersmalley
approved these changes
Aug 27, 2020
Contributor
Author
|
@elasticmachine merge upstream |
Contributor
💚 Build SucceededBuild metrics
History
To update your PR or re-run it, just comment with: |
Contributor
Author
mistic
added a commit
to mistic/kibana
that referenced
this pull request
Aug 31, 2020
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
mistic
added a commit
to mistic/kibana
that referenced
this pull request
Aug 31, 2020
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com> # Conflicts: # packages/elastic-eslint-config-kibana/package.json
mistic
added a commit
that referenced
this pull request
Sep 1, 2020
mistic
added a commit
that referenced
this pull request
Sep 1, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
That PR adds consistency to packages naming by adding an
elasticprefix toeslint-config-kibanapackage.