[Enterprise Search] Migrate util and components from ent-search#76051
Merged
scottybollinger merged 10 commits intoelastic:masterfrom Aug 27, 2020
Merged
[Enterprise Search] Migrate util and components from ent-search#76051scottybollinger merged 10 commits intoelastic:masterfrom
scottybollinger merged 10 commits intoelastic:masterfrom
Conversation
yakhinvadim
reviewed
Aug 27, 2020
...enterprise_search/public/applications/shared/use_did_update_effect/use_did_update_effect.tsx
Outdated
Show resolved
Hide resolved
yakhinvadim
reviewed
Aug 27, 2020
...prise_search/public/applications/shared/use_did_update_effect/use_did_update_effect.test.tsx
Show resolved
Hide resolved
This comment has been minimized.
This comment has been minimized.
yakhinvadim
reviewed
Aug 27, 2020
Contributor
yakhinvadim
left a comment
There was a problem hiding this comment.
Looks good! I only worry about styles:
x-pack/plugins/enterprise_search/public/applications/shared/truncate/truncated_content.tsx
Show resolved
Hide resolved
yakhinvadim
reviewed
Aug 27, 2020
x-pack/plugins/enterprise_search/public/applications/shared/truncate/truncated_content.scss
Outdated
Show resolved
Hide resolved
Contributor
Author
|
@elasticmachine merge upstream |
Contributor
💚 Build SucceededBuild metricsdistributable file count
History
To update your PR or re-run it, just comment with: |
jloleysens
added a commit
to jloleysens/kibana
that referenced
this pull request
Aug 31, 2020
…s-for-710 * 'master' of github.com:elastic/kibana: (43 commits) [APM] Chart units don't update when toggling the chart legends (elastic#74931) [ILM] Add support for frozen phase in UI (elastic#75968) Hides advanced json for count metric (elastic#74636) add client-side feature usage API (elastic#75486) [Maps] add drilldown support map embeddable (elastic#75598) [Enterprise Search] Request handler refactors/enhancements + update existing routes to use shared handler (elastic#76106) [Resolver] model `location.search` in redux (elastic#76140) [APM] Prevent imports of public in server code (elastic#75979) fix eslint issue skip flaky suite (elastic#76223) [APM] Transaction duration anomaly alerting integration (elastic#75719) [Transforms] Avoid using "Are you sure" (elastic#75932) [Security Solution][Exceptions] - Fix bug of alerts not updating after closure from exceptions modal (elastic#76145) [plugin-helpers] improve 3rd party KP plugin support (elastic#75019) [docs/getting-started] link to yarn v1 specifically (elastic#76169) [Security_Solution][Resolver] Resolver loading and error state (elastic#75600) Fixes App Search documentation links (elastic#76133) Fix alerts unable to create / update when the name has trailing whitepace(s) (elastic#76079) [Resolver] Fix useSelector usage (elastic#76129) [Enterprise Search] Migrate util and components from ent-search (elastic#76051) ... # Conflicts: # x-pack/plugins/index_lifecycle_management/public/application/sections/edit_policy/components/data_tier_allocation/node_allocation.tsx # x-pack/plugins/index_lifecycle_management/public/application/sections/edit_policy/edit_policy.tsx # x-pack/plugins/index_lifecycle_management/public/application/services/policies/types.ts # x-pack/plugins/index_lifecycle_management/public/application/services/policies/warm_phase.ts
Contributor
|
Friendly reminder: Looks like this PR hasn’t been backported yet. |
scottybollinger
added a commit
to scottybollinger/kibana
that referenced
this pull request
Aug 31, 2020
…tic#76051) * Migrate useDidUpdateEffect hook Migrates https://github.com/elastic/ent-search/blob/master/app/javascript/shared/utils/useDidUpdateEffect.ts with test added. * Migrate TruncateContent component * Migrate TableHeader component * Remove unused deps * Fix test name * Remove custom type in favor of DependencyList * Add stylesheet for truncated content * Actually import stylesheet 🤦🏼♂️ * Replace legacy mixin Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
scottybollinger
added a commit
that referenced
this pull request
Aug 31, 2020
…) (#76323) * Migrate useDidUpdateEffect hook Migrates https://github.com/elastic/ent-search/blob/master/app/javascript/shared/utils/useDidUpdateEffect.ts with test added. * Migrate TruncateContent component * Migrate TableHeader component * Remove unused deps * Fix test name * Remove custom type in favor of DependencyList * Add stylesheet for truncated content * Actually import stylesheet 🤦🏼♂️ * Replace legacy mixin Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com> Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR migrates the useDidUpdateEffect hook, and the TruncateContent and TableHeader components for use in the Workplace Search migration to Kibana.
These components were migrated with no changes to the logic and tests were added.
Checklist
Delete any items that are not applicable to this PR.
For maintainers