[RUM Dashboard] Rum usability improvement#76024
Conversation
smith
left a comment
There was a problem hiding this comment.
Left some comments. The i18n definitely needs added, but use your discretion for the rest of my comments.
| const items: BreakdownItem[] = [ | ||
| { | ||
| name: 'Browser', | ||
| name: '- No breakdown -', |
There was a problem hiding this comment.
All of these name properties should have i18n translations.
|
|
||
| const onBreakdownChange = (values: BreakdownItem[]) => { | ||
| setBreakdowns(values); | ||
| const onBreakdownChange = (value: BreakdownItem | null) => { |
There was a problem hiding this comment.
Do you need to define this function? Couldn't you just pass onBreakdownChange={setBreakdown} into the BreakdownFilter?
| breakdown: { | ||
| terms: { | ||
| field: breakdownItem.fieldName, | ||
| size: 9, |
There was a problem hiding this comment.
This was mentioned in the issue that we need to show top 9 by volume #69712
| const items: BreakdownItem[] = [ | ||
| { | ||
| name: 'Browser', | ||
| name: '- No breakdown -', |
There was a problem hiding this comment.
I don't think the - adds anything. No breakdown (with i18n) would be fine.
x-pack/plugins/apm/public/components/app/RumDashboard/Breakdowns/BreakdownFilter.tsx
Show resolved
Hide resolved
|
Pinging @elastic/apm-ui (Team:apm) |
|
@elasticmachine merge upstream |
|
@elasticmachine merge upstream |
|
@elasticmachine merge upstream |
💚 Build SucceededBuild metrics@kbn/optimizer bundle module count
async chunks size
History
To update your PR or re-run it, just comment with: |
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
Summary
Fixes #74835
Used a select component for breakdown selector