Added validation to display an error when creating index action in alert with invalid document.#75929
Merged
YulNaumenko merged 2 commits intoelastic:masterfrom Aug 31, 2020
Conversation
…ert with invalid document.
Contributor
|
Pinging @elastic/kibana-alerting-services (Team:Alerting Services) |
mikecote
approved these changes
Aug 31, 2020
Contributor
mikecote
left a comment
There was a problem hiding this comment.
LGTM, works much better 👍
…ex-document-error
Contributor
💚 Build SucceededBuild metricsasync chunks size
page load bundle size
History
To update your PR or re-run it, just comment with: |
YulNaumenko
added a commit
to YulNaumenko/kibana
that referenced
this pull request
Aug 31, 2020
…ert with invalid document. (elastic#75929)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added UI validation for index document:
I've double checked if it is possible to edit an invalid action document value and it is working in master (might be fixed in one of the SO PRs).
Resolve #74769