Skip to content

Adds authenticaton_type as expected property on ES authentication response#75808

Merged
legrego merged 17 commits intoelastic:masterfrom
legrego:security/add-authentication-type
Aug 27, 2020
Merged

Adds authenticaton_type as expected property on ES authentication response#75808
legrego merged 17 commits intoelastic:masterfrom
legrego:security/add-authentication-type

Conversation

@legrego
Copy link
Copy Markdown
Member

@legrego legrego commented Aug 24, 2020 •
edited
Loading

elastic/elasticsearch#61247 introduced a new authentication_type field on the /_security/_authenticate API response. This PR updates our functional tests to expect this new field, and assert on the contents.

This also adds the field to our AuthenticatedUser model, to maintain consistency with the ES model. It is currently unused by Kibana.

Resolves #75707

@legrego legrego added v7.10.0 v8.0.0 chore release_note:skip Skip the PR/issue when compiling release notes Team:Security Platform Security: Auth, Users, Roles, Spaces, Audit Logging, etc t// labels Aug 25, 2020
@legrego legrego marked this pull request as ready for review August 25, 2020 12:01
@legrego legrego requested a review from a team as a code owner August 25, 2020 12:01
@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Aug 25, 2020

Pinging @elastic/kibana-security (Team:Security)

@legrego legrego requested a review from jportner August 25, 2020 12:04
jportner
jportner approved these changes Aug 25, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@jportner jportner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, though I think we have a few opportunities to improve our tests -- see comments below!

@legrego
Copy link
Copy Markdown
Member Author

legrego commented Aug 26, 2020

@elasticmachine merge upstream

@spalger spalger mentioned this pull request Aug 26, 2020
Closed
@legrego
Copy link
Copy Markdown
Member Author

legrego commented Aug 27, 2020

@elasticmachine merge upstream

@kibanamachine
Copy link
Copy Markdown
Contributor

kibanamachine commented Aug 27, 2020

💚 Build Succeeded

Build metrics

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@jfsiii jfsiii mentioned this pull request Aug 27, 2020
Merged
jportner
jportner approved these changes Aug 27, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@jportner jportner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed again -- looks even better now! 😁

@legrego legrego merged commit 54bbd6a into elastic:master Aug 27, 2020
@legrego legrego deleted the security/add-authentication-type branch August 27, 2020 14:09
@legrego legrego mentioned this pull request Aug 27, 2020
Merged
legrego added a commit that referenced this pull request Aug 27, 2020
@legrego @elasticmachine
Adds authenticaton_type as expected property on ES authentication r…
c2f7b2a 
…esponse (#75808) (#76084)

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tylersmalley tylersmalley tylersmalley left review comments

+1 more reviewer

@jportner jportner jportner approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

chore release_note:skip Skip the PR/issue when compiling release notes Team:Security Platform Security: Auth, Users, Roles, Spaces, Audit Logging, etc t// v7.10.0 v8.0.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[ES Snapshot Promotion Failure] security (basic license) Basic authentication should allow access to the API with valid credentials in the header

5 participants

@legrego @elasticmachine @kibanamachine @tylersmalley @jportner