[Security Solution] Add tests for import / export timelines#75537
Merged
angorayc merged 17 commits intoelastic:masterfrom Sep 1, 2020
Merged
[Security Solution] Add tests for import / export timelines#75537angorayc merged 17 commits intoelastic:masterfrom
angorayc merged 17 commits intoelastic:masterfrom
Conversation
Contributor
|
Pinging @elastic/siem (Team:SIEM) |
|
|
||
| export const TIMELINES_TABLE = '[data-test-subj="timelines-table"]'; | ||
|
|
||
| export const BULK_ACTIONS = '.siemUtilityBar__action button'; |
Contributor
There was a problem hiding this comment.
It is possible to add a data-test-subj locator so we can use it instead of the class?
Contributor
Author
There was a problem hiding this comment.
Yup! Thanks a lot, I'll change those selectors.
|
|
||
| export const EXPORT_TIMELINE_ACTION = '[data-test-subj="export-timeline-action"]'; | ||
|
|
||
| export const FIRST_TIMELINE = `${TIMELINES_TABLE} tr td input`; |
Contributor
Author
|
@elasticmachine merge upstream |
MadameSheema
approved these changes
Aug 27, 2020
Contributor
Author
|
@elasticmachine merge upstream |
Contributor
Author
|
@elasticmachine merge upstream |
Contributor
💚 Build SucceededBuild metricsasync chunks size
distributable file count
History
To update your PR or re-run it, just comment with: |
11 tasks
angorayc
added a commit
to angorayc/kibana
that referenced
this pull request
Sep 1, 2020
…75537) * add intergration test for install prebuilt timelines * add integration tests * add functional test for export timeline * clean up * asserts the content of the exported timeline * update selector * update selector * reuses the timeline id from the expected exported file Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com> Co-authored-by: Gloria Hornero <snootchie.boochies@gmail.com>
angorayc
added a commit
that referenced
this pull request
Sep 1, 2020
…76357) * add intergration test for install prebuilt timelines * add integration tests * add functional test for export timeline * clean up * asserts the content of the exported timeline * update selector * update selector * reuses the timeline id from the expected exported file Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com> Co-authored-by: Gloria Hornero <snootchie.boochies@gmail.com> Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com> Co-authored-by: Gloria Hornero <snootchie.boochies@gmail.com>
Contributor
|
Pinging @elastic/security-solution (Team: SecuritySolution) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR is to add happy path tests for import timelines and export timelines.
#69972