[Telemetry] Add Application Usage Schema#75283
Conversation
|
Pinging @elastic/kibana-telemetry (Team:KibanaTelemetry) |
| // TODO: Find a way to update these keys automatically. | ||
| export const applicationUsageSchema = { | ||
| // OSS | ||
| dashboards: commonSchema, |
There was a problem hiding this comment.
I found a few application ids missing:
dashboard (we have both singular and plural)
security_capture_url
siem
alerting_fixture
There was a problem hiding this comment.
@TinaHeiligers, thank you for the ID check.
Q: Did you find them in the Telemetry data from previous versions or in the code?
In the past, we had both: dashboard and dashboards but from 7.9 we only have the plural version of it. siem has been replaced with all the securitySolution:* keys. I tried to keep in here the schema for the active version only.
security_capture_url: I didn't include it because it's a chromeless app with a redirection, so we'll likely don't report anything. Maybe it's worth adding them anyway 🤔
alerting_fixture: is a plugin defined in the x-pack/test directory. Do we need to report those as well?
There was a problem hiding this comment.
Q: Did you find them in the Telemetry data from previous versions or in the code?
In the code, running the master branch.
The others we can leave out.
There was a problem hiding this comment.
I've added all of them (including the forwarding apps) for documentation. We can come back to exclude them later on if we want to 🙂
@TinaHeiligers thank you for noticing 👀
TinaHeiligers
left a comment
There was a problem hiding this comment.
From a first pass, I found a few applications missing from the schema declaration. Code-wise, I'm still reviewing.
|
@elasticmachine merge upstream |
|
@elasticmachine merge upstream |
💚 Build SucceededBuild metrics
History
To update your PR or re-run it, just comment with: |
TinaHeiligers
left a comment
There was a problem hiding this comment.
LGTM.
@Bamieh is working on the schema AST, so he might want to take a look too.
Bamieh
left a comment
There was a problem hiding this comment.
lgtm. i love this improvement
|
Pinging @elastic/kibana-core (Team:Core) |
Summary
Adds the
usageCollection.schemaoption to the Application Usage collector.In order to do so, a few additional changes had to be made in the
@kbn/telemetry-toolspackage in order to support IndexSignatures in interfaces.Resolves #70622
Checklist
Delete any items that are not applicable to this PR.
For maintainers